Implement smart justify -Dj for text -M#5995
Merged
Conversation
Was a lot easier than what it seemed like yesterday. Coffee works. Closes #5986 .
Esteban82
approved these changes
Nov 13, 2021
Esteban82
approved these changes
Nov 13, 2021
There was a complain. I remove an empty space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a lot easier than what it seemed like yesterday. Coffee works. I added a new test (para_offset.sh) that demonstrates it works for a fixed
-Dj3cand various justifications. Curiously, ex17 failed and I found that (probably) due to the bug, we had incorrectly used-Dj-8p/8pto shift the paragraph instead of the correct setting-Dj8p(which did not work until now).Closes #598