Merged
Conversation
Neither grdcontour nor pscontour should allow a zero contour interval. grdcontour should make a plot even if no contours are drawn. This addresses most of #597.
joa-quim
approved these changes
Apr 3, 2019
Count actual contours plotted and if none give a warning.
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
Allow potential to try PyGMT directly without installing anything on their computer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither grdcontour nor pscontour should allow a zero contour interval. grdcontour should make a plot even if no contours are drawn. This addresses most of #597. The case of -C1 with earth_relief_30m is particular since the data are integer and that means contours need to go through every node. This probably hits some crazy logic. However, we dont want to add a special check for the earth_relief grids. I will see if there is a way to avoid those odd messages.