Skip to content

Revert 889 as it breaks Event Lists block. This code will need to be …#1020

Merged
mauteri merged 1 commit intodevelopfrom
revert-889
Feb 21, 2025
Merged

Revert 889 as it breaks Event Lists block. This code will need to be …#1020
mauteri merged 1 commit intodevelopfrom
revert-889

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Feb 21, 2025

…revisited when we work on Query loop block and still work with upcoming/past archive pages.

Description of the Change

Reverts #889 due to sorting bugs.

Where possible, please also include:

  • verification steps to ensure your change has the desired effects and has not introduced any regressions
  • any benefits that will be realized
  • any alternative implementations or possible drawbacks that you considered
  • screenshots or screencasts
    -->

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @mauteri

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

…revisited when we work on Query loop block and still work with upcoming/past archive pages.
@github-actions
Copy link
Copy Markdown
Contributor

Preview changes with Playground

You can preview the recent changes for PR#1020 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri marked this pull request as ready for review February 21, 2025 20:21
@mauteri mauteri merged commit 9fa1b14 into develop Feb 21, 2025
14 checks passed
@mauteri mauteri deleted the revert-889 branch February 21, 2025 20:22
@carstingaxion
Copy link
Copy Markdown
Collaborator

carstingaxion commented Jul 13, 2025

Ok, what was the problem @mauteri ?

I'm willing to fix this in #962 but don't want to have to search for the problem.

@mauteri
Copy link
Copy Markdown
Contributor Author

mauteri commented Jul 13, 2025

I don't recall exactly, PR will need to be reversed in a branch and tested.

carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants