Introduce Event Query Block Variation#962
Conversation
PR Summary
|
|
I'm sorry, this took so long, is not well described and was not a very „friendly“ PR for anyone to contribute to. I’m willing to finish this, if it’s not already obsolete because you did something better in the last couple of months. Let me know if you (as the GatherPress community) are still interested in this piece of code? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…plugin prefix. Found: "gpql_query_vars"
Bildschirmaufzeichnung.vom.09.07.2025.14.01.05.mp4
Ignoring the fact, that none of the existing GatherPress blocks do work with the Event Query block, it's finished. What will or have to happen now @mauteri, @MervinHernandez and @patriciabt ? |
…es and 2. inherited queries
test/unit/php/includes/tests/core/classes/class-test-event-query.php
Outdated
Show resolved
Hide resolved
|
Sometimes I can understand your confusion about the GitHub UI @mauteri Like currently where it says:
and shows that there are no open conversations.
How do I get this PR into the final stage and where is this 1 change requested by reviewers with write access? |
(after understanding that it works GatherPress#1124 (comment))
Preview changes with PlaygroundYou can preview the recent changes for PR#962 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
|
@carstingaxion I'll look to do final review and get this merged within next few days. |
|
I can't believe it is merged. Finally and even without additional change-requests. Thanks @mauteri . |
|
@carstingaxion you're acting like I didn't already leave you a couple rounds of feedback 😂 Nice job on this! |
I'm sorry @mauteri, I meant this in reply to your last comment, where you said 'it'll take some days to prepare a final review'. I was absolutely sure, that there will be some things to change. That's why I -totally surprised- said, there were no changes requested. Thank you very much for all the many feedback you gave @mauteri, it helped me and the result a lot! |
Haha, no problem. I found some time so I seized it to review your PR :-) |

This PR introduces a block-variation of the
core/queryblock, called Event Query. This block allows for everything a normal query block can do including the following:Allows users to select from explicit compositions of block-patterns directly via the blocks Choose (layout) button and the Replace button in the top toolbar.(Planned in Add 'Start blank' patterns for the gatherpress query loop variation. #1124)Allows users to choose starter-content via the blocks Start blank button and the underlying Block Variation Picker.(Planned in Add 'Start blank' patterns for the gatherpress query loop variation. #1124)gatherpress_eventpost, the editor can choose to "Exclude current Event"ORDER BY) of the events by:ORDERcore/queryblock.Description of the Change
Closes #414, closes #599
How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist:
addedupdated tests to cover my change.