chore: remove all-contributors machinery by ethanolivertroy · Pull Request #90 · GRCEngClub/claude-grc-engineering

ethanolivertroy · 2026-04-29T02:29:30Z

Summary

Deletes CONTRIBUTORS.md, .all-contributorsrc, and the all-contributors.yml workflow.
Updates README.md and docs/CONTRIBUTING.md to point at the contributors graph as the recognition source of truth.
Drops the bot-trigger step from docs/FRAMEWORK-PLUGIN-GUIDE.md.
Removes stale CONTRIBUTORS.md references in the teach-me plugin (keeps MAINTAINERS.md).

Why

The bot required a manual @all-contributors please add @user for ... comment after every merge. We weren't doing it consistently — 6 contributors who landed PRs in the past 2 weeks (AnandSundar, DevamShah, jeftekhari, networkbm, FunkeOmolere, plus new contributions from ajy0127) never got added. GitHub's contributors graph already tracks everyone with merged work, automatically and visibly. The CONTRIBUTORS.md file was a maintenance tax with no real benefit, so ripping it out.

Test plan

No remaining all-contributors references outside CHANGELOG.md (which is historical and stays as-is)
No remaining CONTRIBUTORS.md links outside CHANGELOG.md
Manifest validation CI passes
Lychee link-check passes (no new broken links)

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores
- Removed all-contributors automation system and configuration files.
Documentation
- Updated contributor recognition to use GitHub's built-in contributors graph.
- Simplified contribution and framework plugin documentation by removing automation-related instructions.

GitHub's contributors graph already tracks everyone who lands a PR — no separate file or bot to maintain. Drops the maintenance tax + the manual trigger step that was getting skipped anyway. Removes: - CONTRIBUTORS.md (was 2 entries; 6 contributors went unrecognized) - .all-contributorsrc - .github/workflows/all-contributors.yml - README/CONTRIBUTING references to the bot trigger comment - teach-me skill references to CONTRIBUTORS.md (kept MAINTAINERS.md) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-04-29T02:29:42Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2682012d-adf0-4e3a-a231-1f3b337edce5

📥 Commits

Reviewing files that changed from the base of the PR and between b87bc99 and 0fcbb16.

📒 Files selected for processing (8)

.all-contributorsrc
.github/workflows/all-contributors.yml
CONTRIBUTORS.md
README.md
docs/CONTRIBUTING.md
docs/FRAMEWORK-PLUGIN-GUIDE.md
plugins/teach-me/commands/role.md
plugins/teach-me/skills/framework-tutor/SKILL.md

📝 Walkthrough

Walkthrough

This pull request removes the all-contributors bot workflow system and its associated configuration, replacing contributor attribution with GitHub's native contributors graph. Multiple documentation files are updated to reflect this change.

Changes

Cohort / File(s)	Summary
All-Contributors System Removal `.all-contributorsrc`, `.github/workflows/all-contributors.yml`, `CONTRIBUTORS.md`	Removed all-contributors bot configuration, workflow automation, and contributor attribution file that previously tracked and displayed project contributors.
Documentation Updates `README.md`, `docs/CONTRIBUTING.md`, `docs/FRAMEWORK-PLUGIN-GUIDE.md`	Updated community contribution recognition guidance to reference GitHub's native contributors graph instead of the all-contributors bot workflow and manual update instructions.
Teaching Materials Updates `plugins/teach-me/commands/role.md`, `plugins/teach-me/skills/framework-tutor/SKILL.md`	Updated role onboarding resources to reference only `MAINTAINERS.md` instead of both `MAINTAINERS.md` and `CONTRIBUTORS.md`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

feat(teach-me): /teach-me primer + drill plugin (closes #61) #80: Adds functionality that reads CONTRIBUTORS.md, which conflicts with this PR's removal of that file and its references.

Poem

🐰 The contributors bot hops away,
GitHub's graph takes the spotlight today,
No more workflows to tend and maintain,
Just native metrics—simpler, plain! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/remove-all-contributors

_{Review rate limit: 1/3 review remaining, refill in 28 minutes and 18 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-04-29T02:30:41Z

Greptile Summary

This PR removes the all-contributors bot machinery (.all-contributorsrc, the GitHub Actions workflow, and CONTRIBUTORS.md) and replaces every reference to it with a link to GitHub's native contributors graph. All eight affected files are updated consistently — no stale references remain outside of CHANGELOG.md (historical, intentionally kept).

Confidence Score: 5/5

Safe to merge — purely a documentation and workflow cleanup with no logic or functional changes.

All removals are complete and consistent. No broken links introduced, no code paths affected, no remaining stale references outside the intentionally-preserved CHANGELOG.md. The pending CI checks (manifest validation, Lychee link-check) are the only outstanding items and are expected to pass given the nature of the changes.

No files require special attention.

Important Files Changed

Filename	Overview
.all-contributorsrc	Deleted — bot configuration no longer needed.
.github/workflows/all-contributors.yml	Deleted — GitHub Actions workflow that triggered the all-contributors bot is removed cleanly.
CONTRIBUTORS.md	Deleted — manually-maintained contributors list replaced by GitHub's automatic contributors graph.
README.md	Recognition line updated to point at GitHub contributors graph; change is accurate and links correctly.
docs/CONTRIBUTING.md	Bot-invoke instructions removed from Recognition section; replaced with a single accurate sentence pointing to the contributors graph.
docs/FRAMEWORK-PLUGIN-GUIDE.md	Step 6 (bot-trigger comment after merge) removed from the plugin contribution workflow; remaining steps are intact.
plugins/teach-me/commands/role.md	CONTRIBUTORS.md reference removed from skill read-list; MAINTAINERS.md reference preserved correctly.
plugins/teach-me/skills/framework-tutor/SKILL.md	Step 4 updated to read only MAINTAINERS.md; CONTRIBUTORS.md reference cleanly dropped.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Contributor opens PR] --> B[PR merges]
    B --> C{Before this PR}
    B --> D{After this PR}

    C --> E["Maintainer comments\n@all-contributors please add\n@user for code,doc"]
    E --> F[all-contributors bot\nworkflow triggers]
    F --> G[Bot commits update\nto CONTRIBUTORS.md]
    G --> H["CONTRIBUTORS.md\n(manually maintained)"]
    H --> I[Often skipped —\n6 contributors missed\nin 2 weeks]

    D --> J[GitHub automatically\ntracks contribution]
    J --> K[Contributors Graph\ngraphs/contributors]
    K --> L[Always up to date,\nzero maintenance]

_{Reviews (1): Last reviewed commit: "chore: remove all-contributors machinery" | Re-trigger Greptile}

Copilot

Pull request overview

Removes the repository’s all-contributors bot workflow/config and transitions contributor recognition docs to use GitHub’s built-in contributors graph as the single source of truth.

Changes:

Deletes CONTRIBUTORS.md, .all-contributorsrc, and the all-contributors GitHub Actions workflow.
Updates contributor-recognition guidance in README.md and docs/CONTRIBUTING.md to point to the GitHub contributors graph.
Removes stale references to CONTRIBUTORS.md / bot invocation steps in the framework guide and teach-me plugin docs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
plugins/teach-me/skills/framework-tutor/SKILL.md	Removes instruction to read `CONTRIBUTORS.md`; keeps `MAINTAINERS.md` as the reference.
plugins/teach-me/commands/role.md	Updates `/teach-me:role` delegation notes to no longer mention `CONTRIBUTORS.md`.
docs/FRAMEWORK-PLUGIN-GUIDE.md	Removes the post-merge `@all-contributors` bot invocation step.
docs/CONTRIBUTING.md	Replaces all-contributors bot instructions with a link to the GitHub contributors graph.
README.md	Updates “Recognition” blurb to reference the GitHub contributors graph.
CONTRIBUTORS.md	Deletes the all-contributors generated contributors list file.
.github/workflows/all-contributors.yml	Deletes the workflow that ran the all-contributors bot on PR comments.
.all-contributorsrc	Deletes the all-contributors configuration file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Two broken external URLs were failing the lychee link-check on every PR: 1. mattpocock/skills/grill-me — Matt reorganized into category subdirectories; new path is skills/productivity/grill-me. 3 references updated (CHANGELOG.md, plugins/teach-me/README.md, plugins/teach-me/commands/quiz.md). 2. www.edoeb.admin.ch/edoeb/en/home.html — 301-redirects to /en, but lychee's user agent gets a bot-detection 500 from the FDPIC origin. Switched both ch-fadp references to the canonical /en URL. PRs #87, #89, and #90 all hit these failures.

Copilot AI review requested due to automatic review settings April 29, 2026 02:29

ethanolivertroy requested a review from a team as a code owner April 29, 2026 02:29

Copilot started reviewing on behalf of ethanolivertroy April 29, 2026 02:29 View session

ethanolivertroy merged commit 9b90bce into main Apr 29, 2026
3 of 5 checks passed

Copilot AI reviewed Apr 29, 2026

View reviewed changes

ethanolivertroy mentioned this pull request Apr 29, 2026

fix(docs): update mattpocock/skills/grill-me URL #91

Merged

2 tasks

ethanolivertroy deleted the chore/remove-all-contributors branch May 4, 2026 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: remove all-contributors machinery#90

chore: remove all-contributors machinery#90
ethanolivertroy merged 1 commit into
mainfrom
chore/remove-all-contributors

ethanolivertroy commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ethanolivertroy commented Apr 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ethanolivertroy commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading