Skip to content

fix(docs): update mattpocock/skills/grill-me URL#91

Merged
ethanolivertroy merged 2 commits into
mainfrom
fix/lychee-grill-me-url
Apr 29, 2026
Merged

fix(docs): update mattpocock/skills/grill-me URL#91
ethanolivertroy merged 2 commits into
mainfrom
fix/lychee-grill-me-url

Conversation

@ethanolivertroy

@ethanolivertroy ethanolivertroy commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Updates 3 references to mattpocock/skills/grill-me to the new path skills/productivity/grill-me. Matt reorganized the skills repo into category subdirectories.

Why

This single broken link has been failing the lychee link-check on every PR for the past few days (#87, #89, #90 all hit it). Verified the new URL resolves 200.

Test plan

  • curl -sI .../skills/productivity/grill-me → 200
  • Lychee CI passes on this PR

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated external reference links in the teach-me plugin to correct documentation URLs.

Matt reorganized the skills repo into category subdirectories;
grill-me now lives at skills/productivity/grill-me. Three references
(CHANGELOG.md, plugins/teach-me/README.md, plugins/teach-me/commands/quiz.md)
all 404'd, which has been failing the lychee link-check on every PR for the
last few days.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 29, 2026 02:36
@ethanolivertroy ethanolivertroy requested a review from a team as a code owner April 29, 2026 02:36
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@ethanolivertroy has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d25712b1-ba91-4802-a18e-dca32b3169f6

📥 Commits

Reviewing files that changed from the base of the PR and between be1a68d and 64dd852.

📒 Files selected for processing (2)
  • plugins/frameworks/ch-fadp/README.md
  • plugins/frameworks/ch-fadp/skills/ch-fadp-expert/SKILL.md
📝 Walkthrough

Walkthrough

Updates reference URLs across three documentation files for the teach-me plugin, redirecting the GitHub inspiration source link from a generic path to a more specific skills/productivity directory path. All changes are documentation-only with no functional modifications.

Changes

Cohort / File(s) Summary
Documentation URL Updates
CHANGELOG.md, plugins/teach-me/README.md, plugins/teach-me/commands/quiz.md
Updates the reference URL for the teach-me plugin's inspiration source from mattpocock/skills/grill-me to the more specific mattpocock/skills/skills/productivity/grill-me path across documentation and changelog entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A path once lost, now found with care,
Through productivity's directory lair,
The skills of grill now properly placed,
In folders neat, with URLs graced! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating a broken documentation link from mattpocock/skills/grill-me to the new path. It directly reflects the primary purpose of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lychee-grill-me-url

Review rate limit: 0/3 reviews remaining, refill in 3 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Old URL 301-redirects to /en. lychee's action fetches the original and
gets a bot-detection 500 from the FDPIC site, failing link-check on
every PR. Canonical URL renders fine for lychee and humans alike.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates broken documentation links to the reorganized mattpocock/skills repository so CI link-checking (lychee) no longer fails.

Changes:

  • Updated the grill-me GitHub URL in /teach-me:quiz command docs.
  • Updated the same URL reference in the teach-me plugin README.
  • Updated the same URL reference in the project changelog entry for teach-me v0.1.0.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

File Description
plugins/teach-me/commands/quiz.md Fixes the grill-me inspiration link to the new skills/productivity/grill-me path.
plugins/teach-me/README.md Fixes the grill-me inspiration link in the command list to the new path.
CHANGELOG.md Fixes the grill-me inspiration link in the Unreleased teach-me entry to the new path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# /teach-me:quiz

Drill yourself on a framework with application-level questions. Ask, evaluate, ask again. Inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/grill-me).
Drill yourself on a framework with application-level questions. Ask, evaluate, ask again. Inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me).

Copilot AI Apr 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link target has been updated to the new path, but the visible link text still reads mattpocock/skills/grill-me, which looks like the old location. Consider updating the link text (or making it a more generic label) so it matches the new URL and avoids confusion when someone reads the docs.

Suggested change
Drill yourself on a framework with application-level questions. Ask, evaluate, ask again. Inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me).
Drill yourself on a framework with application-level questions. Ask, evaluate, ask again. Inspired by [Matt Pocock's grill-me skill](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me).

Copilot uses AI. Check for mistakes.
- `/teach-me:control` — pulls a control from the [SCF crosswalk](https://grcengclub.github.io/scf-api/) and explains it once, with the mapped framework controls listed below. Useful when "what does CHG-02 mean and where does it show up?" is the actual question.
- `/teach-me:role` — what a `grc-engineer`, `grc-auditor`, `grc-internal`, or `grc-tprm` practitioner does day-to-day, what they touch in this toolkit, and where to start.
- `/teach-me:quiz` — Socratic drill (inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/grill-me)). Asks you a control-application question, evaluates your answer, asks another. Tracks which control families you've covered. Stops when you say so.
- `/teach-me:quiz` — Socratic drill (inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me)). Asks you a control-application question, evaluates your answer, asks another. Tracks which control families you've covered. Stops when you say so.

Copilot AI Apr 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is updated, but the displayed link text still suggests the old repo path (mattpocock/skills/grill-me). Updating the link text to reflect the new path will make the reference clearer for readers.

Suggested change
- `/teach-me:quiz` — Socratic drill (inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me)). Asks you a control-application question, evaluates your answer, asks another. Tracks which control families you've covered. Stops when you say so.
- `/teach-me:quiz` — Socratic drill (inspired by [`mattpocock/skills/productivity/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me)). Asks you a control-application question, evaluates your answer, asks another. Tracks which control families you've covered. Stops when you say so.

Copilot uses AI. Check for mistakes.
Comment thread CHANGELOG.md
### Added

- **`teach-me` plugin (v0.1.0).** Socratic primer + drill plugin for new-to-GRC practitioners and career transitioners — the on-ramp the toolkit was missing for people who don't already know the framework. Four commands: `/teach-me:framework <name>` produces a paraphrased primer (purpose, scope, artifacts, cadence, regulator, control families), `/teach-me:control <id>` explains one control across every framework it maps to via the SCF crosswalk, `/teach-me:role <persona>` outputs a first-90-days onboarding for the four GRC personas, and `/teach-me:quiz <framework>` runs a Socratic drill loop (inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/grill-me)) that tracks coverage in-session. Reuses `/grc-engineer:map-controls-unified` and `/grc-engineer:frameworks` rather than duplicating the SCF client. No normative standard text is reproduced. Closes [#61](https://github.com/GRCEngClub/claude-grc-engineering/issues/61).
- **`teach-me` plugin (v0.1.0).** Socratic primer + drill plugin for new-to-GRC practitioners and career transitioners — the on-ramp the toolkit was missing for people who don't already know the framework. Four commands: `/teach-me:framework <name>` produces a paraphrased primer (purpose, scope, artifacts, cadence, regulator, control families), `/teach-me:control <id>` explains one control across every framework it maps to via the SCF crosswalk, `/teach-me:role <persona>` outputs a first-90-days onboarding for the four GRC personas, and `/teach-me:quiz <framework>` runs a Socratic drill loop (inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me)) that tracks coverage in-session. Reuses `/grc-engineer:map-controls-unified` and `/grc-engineer:frameworks` rather than duplicating the SCF client. No normative standard text is reproduced. Closes [#61](https://github.com/GRCEngClub/claude-grc-engineering/issues/61).

Copilot AI Apr 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog entry updates the URL, but the visible link label still shows mattpocock/skills/grill-me (the pre-reorg path). Consider updating the link text to match the new location for clarity.

Suggested change
- **`teach-me` plugin (v0.1.0).** Socratic primer + drill plugin for new-to-GRC practitioners and career transitioners — the on-ramp the toolkit was missing for people who don't already know the framework. Four commands: `/teach-me:framework <name>` produces a paraphrased primer (purpose, scope, artifacts, cadence, regulator, control families), `/teach-me:control <id>` explains one control across every framework it maps to via the SCF crosswalk, `/teach-me:role <persona>` outputs a first-90-days onboarding for the four GRC personas, and `/teach-me:quiz <framework>` runs a Socratic drill loop (inspired by [`mattpocock/skills/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me)) that tracks coverage in-session. Reuses `/grc-engineer:map-controls-unified` and `/grc-engineer:frameworks` rather than duplicating the SCF client. No normative standard text is reproduced. Closes [#61](https://github.com/GRCEngClub/claude-grc-engineering/issues/61).
- **`teach-me` plugin (v0.1.0).** Socratic primer + drill plugin for new-to-GRC practitioners and career transitioners — the on-ramp the toolkit was missing for people who don't already know the framework. Four commands: `/teach-me:framework <name>` produces a paraphrased primer (purpose, scope, artifacts, cadence, regulator, control families), `/teach-me:control <id>` explains one control across every framework it maps to via the SCF crosswalk, `/teach-me:role <persona>` outputs a first-90-days onboarding for the four GRC personas, and `/teach-me:quiz <framework>` runs a Socratic drill loop (inspired by [`mattpocock/skills/tree/main/skills/productivity/grill-me`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grill-me)) that tracks coverage in-session. Reuses `/grc-engineer:map-controls-unified` and `/grc-engineer:frameworks` rather than duplicating the SCF client. No normative standard text is reproduced. Closes [#61](https://github.com/GRCEngClub/claude-grc-engineering/issues/61).

Copilot uses AI. Check for mistakes.
@ethanolivertroy ethanolivertroy merged commit ba74f10 into main Apr 29, 2026
2 checks passed
@greptile-apps

greptile-apps Bot commented Apr 29, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes three broken grill-me reference links by updating the GitHub URL path from /tree/main/grill-me to /tree/main/skills/productivity/grill-me following a reorganization in the upstream mattpocock/skills repo. It also quietly updates two Swiss FDPIC authority URLs from edoeb.admin.ch/edoeb/en/home.html to edoeb.admin.ch/en, which aren't mentioned in the PR title or description but are straightforward link corrections.

Confidence Score: 5/5

Safe to merge — documentation-only link fixes with no logic changes.

All changes are hyperlink URL updates in Markdown files. The new grill-me URL is confirmed reachable (200) and the FDPIC URL is a standard authority domain redirect. No code paths, data, or logic are touched.

No files require special attention.

Important Files Changed

Filename Overview
CHANGELOG.md Updates grill-me hyperlink URL from /tree/main/grill-me to /tree/main/skills/productivity/grill-me; link display text unchanged
plugins/teach-me/README.md Updates grill-me hyperlink URL to new reorganized path; no other changes
plugins/teach-me/commands/quiz.md Updates grill-me hyperlink URL to new reorganized path; no other changes
plugins/frameworks/ch-fadp/README.md Updates Swiss FDPIC link from edoeb.admin.ch/edoeb/en/home.html to edoeb.admin.ch/en; not mentioned in PR description
plugins/frameworks/ch-fadp/skills/ch-fadp-expert/SKILL.md Updates Swiss FDPIC link to same new URL as ch-fadp/README.md; not mentioned in PR description

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Lychee link-check CI"] -->|"fails on broken URL"| B["Old: /tree/main/grill-me"]
    B -->|"404 / redirect"| C["❌ CI failure on PRs 87, 89, 90"]
    A -->|"passes on fixed URL"| D["New: /tree/main/skills/productivity/grill-me"]
    D -->|"200 OK"| E["✅ CI passes"]
    F["FDPIC URL: /edoeb/en/home.html"] -->|"updated"| G["FDPIC URL: /en"]
    subgraph "Files updated"
        H["CHANGELOG.md"]
        I["plugins/teach-me/README.md"]
        J["plugins/teach-me/commands/quiz.md"]
        K["plugins/frameworks/ch-fadp/README.md"]
        L["plugins/frameworks/ch-fadp/skills/ch-fadp-expert/SKILL.md"]
    end
Loading

Reviews (1): Last reviewed commit: "fix(ch-fadp): point at canonical FDPIC U..." | Re-trigger Greptile

@ethanolivertroy ethanolivertroy deleted the fix/lychee-grill-me-url branch May 4, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants