feat(ETH): balance event streaming for ETH by onur-ozkan · Pull Request #2041 · GLEECBTC/komodo-defi-framework

onur-ozkan · 2023-12-21T07:54:16Z

This PR aims to:

Implement balance events for ETH.
Implement error events.

Can be tested in a same way of #1978 PR.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

…h-balance-stream-event

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan · 2024-01-08T13:14:23Z

mm2src/coins/eth/eth_balance_events.rs

+    async fn handle(self, interval: f64, tx: oneshot::Sender<EventInitStatus>) {
+        const RECEIVER_DROPPED_MSG: &str = "Receiver is dropped, which should never happen.";
+
+        async fn with_socket(_coin: EthCoin, _ctx: MmArc) { todo!() }


Socket support is blocked by GLEECBTC/komodo-defi-proxy#18 implementation which shouldn't be a blocker for review/merge in my opinion (if we review/merge this PR at this stage, GUI devs can start implementing balance streaming for eth,cosmos,utxo protocols).

laruh

Thanks for this enhancement! I have a question for now.

mm2src/coins/eth.rs

laruh

Thanks for the fix! next review notes

mm2src/coins/eth/eth_balance_events.rs

mm2src/coins/tendermint/tendermint_balance_events.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

borngraced

Great work!
Just one note from me 😃

mm2src/coins/eth.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

laruh

LGTM!

shamardy · 2024-01-22T18:26:08Z

mm2src/coins/eth/eth_balance_events.rs

+        (
+            coin.address_balance(coin.my_address)
+                .compat()
+                .await
+                .map_err(|e| (token_ticker.clone(), e))?,
+            coin.decimals,
+        )
+    } else {
+        (
+            coin.get_token_balance_by_address(info.token_address)
+                .await
+                .map_err(|e| (token_ticker.clone(), e))?,
+            info.decimals,
+        )


Since this PR will be merged before #1979
This is just a reminder for me to implement balance streaming for all addresses in the HD wallet similar to how it's done for utxos.

shamardy

🔥

borngraced

LGTM! 🚀 and great work

shamardy · 2024-01-25T18:47:57Z

@KomodoPlatform/qa I merged this PR since it's needed to continue work here #2058 QA/testing can be done when the other PR is ready or in dev.

* evm-hd-wallet: (27 commits) Fix todo comments Fix HDAddressOps::Address trait bounds fix(indexeddb): fix IDB cursor.continue_() call after drop (GLEECBTC#2028) security bump for `h2` (GLEECBTC#2062) fix(makerbot): allow more than one prices url in makerbot (GLEECBTC#2027) fix(wasm worker env): refactor direct usage of `window` (GLEECBTC#1953) feat(nft): nft abi in withdraw_nft RPC, clear_nft_db RPC (GLEECBTC#2039) refactor(utxo): refactor utxo output script creation (GLEECBTC#1960) feat(ETH): balance event streaming for ETH (GLEECBTC#2041) chore(release): bump mm2 version to 2.1.0-beta (GLEECBTC#2044) feat(trezor): add segwit support for withdraw with trezor (GLEECBTC#1984) chore(config): remove vscode launchjson (GLEECBTC#2040) feat(trading-proto-upgrade): wasm DB, kickstart, refund states, v2 RPCs (GLEECBTC#2015) feat(UTXO): balance event streaming for Electrum clients (GLEECBTC#2013) feat(tx): add new sign_raw_transaction rpc for UTXO and EVM coins (GLEECBTC#1930) fix(p2p): handle encode_and_sign errors (GLEECBTC#2038) chore(release): add changelog entries for v2.0.0-beta (GLEECBTC#2037) chore(network): write network information to stdout (GLEECBTC#2034) fix(price_endpoints): add cached url (GLEECBTC#2032) deps(network): sync with upstream yamux (GLEECBTC#2030) ...

* dev: feat(zcoin): ARRR WASM implementation (GLEECBTC#1957) feat(trading-proto-upgrade): locked amounts, kmd burn and other impl (GLEECBTC#2046) fix(indexeddb): set stop on success cursor condition (GLEECBTC#2067) feat(config): add `max_concurrent_connections` to mm2 config (GLEECBTC#2063) feat(stats_swaps): add gui/mm_version in stats db (GLEECBTC#2061) fix(indexeddb): fix IDB cursor.continue_() call after drop (GLEECBTC#2028) security bump for `h2` (GLEECBTC#2062) fix(makerbot): allow more than one prices url in makerbot (GLEECBTC#2027) fix(wasm worker env): refactor direct usage of `window` (GLEECBTC#1953) feat(nft): nft abi in withdraw_nft RPC, clear_nft_db RPC (GLEECBTC#2039) refactor(utxo): refactor utxo output script creation (GLEECBTC#1960) feat(ETH): balance event streaming for ETH (GLEECBTC#2041) chore(release): bump mm2 version to 2.1.0-beta (GLEECBTC#2044) feat(trezor): add segwit support for withdraw with trezor (GLEECBTC#1984)

onur-ozkan added 9 commits December 18, 2023 15:43

create eth_balance_events module

6c738f7

Signed-off-by: onur-ozkan <work@onurozkan.dev>

save dev state

108518f

Signed-off-by: onur-ozkan <work@onurozkan.dev>

add TODO

6d5a739

Signed-off-by: onur-ozkan <work@onurozkan.dev>

enable and broadcast balance events for eth

39b6597

Signed-off-by: onur-ozkan <work@onurozkan.dev>

optimize address handling

ca59704

Signed-off-by: onur-ozkan <work@onurozkan.dev>

handle balances concurrently

3f6809f

Signed-off-by: onur-ozkan <work@onurozkan.dev>

enable eth balance stream on legacy activation

384d8d9

Signed-off-by: onur-ozkan <work@onurozkan.dev>

handle time complexity

aa22f6b

Signed-off-by: onur-ozkan <work@onurozkan.dev>

broadcast error events for eth and tendermint

fcef953

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan added the in progress label Dec 21, 2023

onur-ozkan changed the title ~~Eth balance stream event~~ feat(ETH): balance event streaming for ETH Dec 21, 2023

onur-ozkan added 4 commits December 21, 2023 12:45

broadcast ticker on error events

fd05deb

Signed-off-by: onur-ozkan <work@onurozkan.dev>

use cross-compatible Instant

34cf91e

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into et…

ad0a05e

…h-balance-stream-event

fix TODO for UTXO balance stream

161f20a

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan commented Jan 8, 2024

View reviewed changes

onur-ozkan added enhancement and removed in progress labels Jan 8, 2024

shamardy requested a review from laruh January 15, 2024 10:08

laruh reviewed Jan 16, 2024

View reviewed changes

mm2src/coins/eth.rs Outdated Show resolved Hide resolved

laruh suggested changes Jan 17, 2024

View reviewed changes

mm2src/coins/eth/eth_balance_events.rs Outdated Show resolved Hide resolved

mm2src/coins/eth/eth_balance_events.rs Show resolved Hide resolved

mm2src/coins/eth/eth_balance_events.rs Show resolved Hide resolved

mm2src/coins/tendermint/tendermint_balance_events.rs Show resolved Hide resolved

revert BTreeMap

fb0eb96

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the eth-balance-stream-event branch from c92710f to fb0eb96 Compare January 17, 2024 15:03

split balance logic in get_all_balance_results_concurrently

e76c141

Signed-off-by: onur-ozkan <work@onurozkan.dev>

borngraced suggested changes Jan 17, 2024

View reviewed changes

mm2src/coins/eth.rs Show resolved Hide resolved

abstract eth balance stream spawn

dc8bfad

Signed-off-by: onur-ozkan <work@onurozkan.dev>

dimxy mentioned this pull request Jan 17, 2024

feat(ETH): eip1559 gas fee estimator and rpcs #2051

Merged

19 tasks

add interval to the error log

6dbd85b

Signed-off-by: onur-ozkan <work@onurozkan.dev>

laruh approved these changes Jan 22, 2024

View reviewed changes

shamardy reviewed Jan 22, 2024

View reviewed changes

shamardy mentioned this pull request Jan 22, 2024

feat(hd_wallet): evm hd wallet and trezor #1979

Merged

8 tasks

shamardy approved these changes Jan 22, 2024

View reviewed changes

shamardy added sec-review labels Jan 22, 2024

shamardy requested review from Alrighttt, ca333 and smk762 January 22, 2024 18:34

borngraced approved these changes Jan 23, 2024

View reviewed changes

onur-ozkan mentioned this pull request Jan 23, 2024

feat(ETH transport & heartbeats): various enhancements/features #2058

Merged

8 tasks

shamardy merged commit 8635ed9 into dev Jan 25, 2024

shamardy deleted the eth-balance-stream-event branch January 25, 2024 18:45

harsenyan3 mentioned this pull request Jul 16, 2024

Add info on Error Events to docs GLEECBTC/komodo-docs-mdx#279

Closed

shamardy mentioned this pull request Aug 1, 2024

chore(release): v2.1.0-beta #2043

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ETH): balance event streaming for ETH#2041

feat(ETH): balance event streaming for ETH#2041
shamardy merged 17 commits intodevfrom
eth-balance-stream-event

onur-ozkan commented Dec 21, 2023 •

edited

Loading

Uh oh!

onur-ozkan Jan 8, 2024 •

edited

Loading

Uh oh!

laruh left a comment

Uh oh!

Uh oh!

laruh left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

borngraced left a comment

Uh oh!

Uh oh!

laruh left a comment

Uh oh!

shamardy Jan 22, 2024 •

edited

Loading

Uh oh!

shamardy left a comment

Uh oh!

borngraced left a comment

Uh oh!

shamardy commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

onur-ozkan commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onur-ozkan Jan 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laruh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

laruh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

borngraced left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

laruh left a comment

Choose a reason for hiding this comment

Uh oh!

shamardy Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

borngraced left a comment

Choose a reason for hiding this comment

Uh oh!

shamardy commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

onur-ozkan commented Dec 21, 2023 •

edited

Loading

onur-ozkan Jan 8, 2024 •

edited

Loading

shamardy Jan 22, 2024 •

edited

Loading