feat(hd_wallet): evm hd wallet and trezor by shamardy · Pull Request #1979 · GLEECBTC/komodo-defi-framework

shamardy · 2023-09-29T22:37:04Z

Part of #1838

This is an in progress PR:

Refactor HD wallet functionalities to be separate from utxo so it can be used easily for other coins.
Add HDWallet derivation to EthCoin.
Implement HDWalletCoinOps, HDWalletBalanceOps, etc.. for EthCoin.
Balance streaming for all addresses feat(ETH): balance event streaming for ETH #2041 (comment)
Implement init_platform_coin_with_tokens using task manager for EthCoin.
Implement init_token using task manager.
Maintain backward compatibility.
Doc comments

Changes:

EVM balance streaming now contains address field to support HD wallet
chain_id is needed for all evm coins/tokens. chain_id should be part of platform coin config only actually and retrieved from platform coin, this is for v2 methods, but we should keep it in all coins config for v1 methods.

…utxo

…ss all coins

artemii235

Great work!
It seems that few traits can be removed, which will hopefully make code simpler 🙂

mm2src/coins/hd_wallet/mod.rs

mm2src/coins/hd_wallet/errors.rs

…function

artemii235

Few minor notes 🙂

mm2src/coins/coin_balance.rs

mm2src/coins/hd_wallet/mod.rs

artemii235

👍

shamardy · 2023-10-09T12:12:48Z

Thanks you for the review @artemii235, I will continue working through this list #1979 (comment) in this sprint by adding new commits to this PR, so next review in a few weeks should be for commits after this comment only to make it easier to review :)

mm2src/coins/hd_wallet/mod.rs

…ke it generic

…_addresses rpcs for evm

…ons there

…refactor some swap methods to be async

mm2src/coins/hd_wallet/pubkey.rs

mm2src/coins/eth/eth_balance_events.rs

mm2src/coins/eth/eth_hd_wallet.rs

laruh · 2024-04-03T13:40:06Z

mm2src/coins/hd_wallet/coin_ops.rs

+            .collect()
+    }
+
+    // Todo: combine both implementations once worker threads are supported in WASM


Could you remind me please, as far as I remember we added worker support in wasm, right?
Do we need something else for this todo?

Workers need to be supported from the GUI side as well by adding a worker file for this and implementing any needed code in the worker file if there is any.

…pubkey_impl`

…vationMethod` and implement a default implementation for it * Remove `my_addresses` from `utxo_tx_history_v2_common.rs` and use `all_addresses` in place of it

mm2src/coins_activation/src/eth_with_token_activation.rs

…WithTokensError::Internal` error

…aming channel

shamardy · 2024-04-08T19:41:09Z

@dimxy @laruh are you working on any more review iterations for this PR? If not can you please check if all comments are fixed and approve the PR so I can merge it.

shamardy · 2024-04-08T19:41:47Z

@onur-ozkan just need you to check this change #1979 (comment) and if it's alright by you.

laruh

LGTM! 🔥

dimxy

LGTM

…wallet

…to `ERC20DEV` conf

* Add address_formatter higher-order function to HDWalletCoinOps to display eth addresses correctly * add enable_eth_with_tokens_v2 test helper * fix test_enable_eth_erc20_coins_with_enable_hd * fix test_withdraw_and_send_hd_eth_erc20

* remove `wasm_test_withdraw_eth` and `test_send` since they use `ETH_DEV_NODE` # ignore `swap_usdc_ibc_with_nimda` since it needs periodical funding

…he address was funded

…see if that fixes things

…ts can still be unstable

shamardy added 4 commits September 22, 2023 23:04

wip: move hd_wallet.rs into a mod along with storage

921e281

move hd_confirm_address.rs to hd_wallet mod

83ade83

move hd_pubkey.rs to hd_wallet mod

64932d9

remove hd prefix from file names in hd_wallet mod

edfc928

shamardy added the in progress label Sep 29, 2023

wip: create hd_wallet mod to separate hd wallet functionalities from …

bd5cfd4

…utxo

shamardy force-pushed the evm-hd-wallet branch from 412ec5e to bd5cfd4 Compare September 29, 2023 22:40

shamardy requested review from artemii235 and dimxy October 2, 2023 11:51

make set_known_addresses_number to have a default implementation acro…

73b8b84

…ss all coins

artemii235 suggested changes Oct 3, 2023

View reviewed changes

shamardy added 2 commits October 4, 2023 17:03

rename NewAccountCreatingError to NewAccountCreationError

aadf904

return Self::Address instead of reference from HDAddressOps::address …

975c6fa

…function

artemii235 suggested changes Oct 6, 2023

View reviewed changes

derive copy for HDAccountAddressId + other refactors

4d6e468

artemii235 approved these changes Oct 9, 2023

View reviewed changes

convert create_new_account to a generic function

5114cc1

dimxy reviewed Oct 12, 2023

View reviewed changes

mm2src/coins/hd_wallet/mod.rs Show resolved Hide resolved

shamardy added 11 commits October 16, 2023 15:44

remove address_format field from generic HDWallet impl

731b27c

move UtxoHDWallet and it's impl to utxo_hd_wallet.rs

8d7cf6d

create HDCoinWithdrawOps and move get_withdraw_hd_sender to it and ma…

038e0bd

…ke it generic

wip: Add HDWallet derivation and implement HD coin ops for ETHCoin

1672197

refactor is_address_used impl for ETHAddressScanner

2d42b3e

move scan_for_new_addresses_impl to lp_coins.rs for now

7658417

enable account_balance, get_new_address, create_account, scan_for_new…

e6b686e

…_addresses rpcs for evm

create eth_hd_wallet.rs and move eth hd wallet types and implementati…

e8add69

…ons there

make extract_extended_pubkey function common for all coins

30080bb

do concurrent call for addresses balances

e842165

remove address EthCoinImpl since it's included in derivation_method, …

dd1d4c0

…refactor some swap methods to be async

dimxy reviewed Apr 2, 2024

View reviewed changes

mm2src/coins/hd_wallet/pubkey.rs Show resolved Hide resolved

dimxy reviewed Apr 3, 2024

View reviewed changes

mm2src/coins/hd_wallet/pubkey.rs Show resolved Hide resolved

laruh suggested changes Apr 3, 2024

View reviewed changes

shamardy added 3 commits April 3, 2024 23:54

fix: Rename common fn extract_extended_pubkey to `extract_extended_…

fb1ccd7

…pubkey_impl`

fix: document ExtractExtendedPubkey trait

faaae10

fix: rename my_addresses to all_addresses add it to `CoinWithDeri…

26cca4b

…vationMethod` and implement a default implementation for it * Remove `my_addresses` from `utxo_tx_history_v2_common.rs` and use `all_addresses` in place of it

shamardy mentioned this pull request Apr 4, 2024

feat(nft-swap): nft swap protocol v2 POC #2084

Merged

dimxy reviewed Apr 5, 2024

View reviewed changes

mm2src/coins_activation/src/eth_with_token_activation.rs Outdated Show resolved Hide resolved

fix: map EthActivationV2Error::ChainIdNotSet to `EnablePlatformCoin…

2201300

…WithTokensError::Internal` error

shamardy mentioned this pull request Apr 5, 2024

use settings from parent chain for tokens #756

Open

fix: create a common registry for events and error events of the stre…

2d8b0e2

…aming channel

laruh approved these changes Apr 8, 2024

View reviewed changes

shamardy mentioned this pull request Apr 9, 2024

Implementing Per-Coin Database Paths Based on PubkeyHash for Enhanced Modularization #2094

Open

dimxy mentioned this pull request Apr 11, 2024

feat(ETH): eip1559 gas fee estimator and rpcs #2051

Merged

19 tasks

shamardy mentioned this pull request Apr 12, 2024

fix(tests): fix failing tests #2085

Merged

5 tasks

dimxy approved these changes Apr 16, 2024

View reviewed changes

shamardy added 10 commits April 16, 2024 20:06

Merge remote-tracking branch 'origin/hd-account-balance' into evm-hd-…

9462346

…wallet

post-merge fixes: reduce arguments in sign_and_send_transaction

b1d6d62

post-merge test fixes: fix test_buy_conf_settings by adding chain_id …

2017c22

…to `ERC20DEV` conf

post-merge fixes:

031add3

* Add address_formatter higher-order function to HDWalletCoinOps to display eth addresses correctly * add enable_eth_with_tokens_v2 test helper * fix test_enable_eth_erc20_coins_with_enable_hd * fix test_withdraw_and_send_hd_eth_erc20

post-merge test fixes: fix docker tests

8e59228

post-merge test fixes:

8c41e55

* remove `wasm_test_withdraw_eth` and `test_send` since they use `ETH_DEV_NODE` # ignore `swap_usdc_ibc_with_nimda` since it needs periodical funding

post-merge test fixes: fix fmt

66673b7

post-merge test fixes: unignore swap_usdc_ibc_with_nimda test after t…

b9890e6

…he address was funded

post-merge test fixes: increase WASM_BINDGEN_TEST_TIMEOUT to 420 and …

862476c

…see if that fixes things

post-merge test fixes: fix some issues in swap watcher test, some tes…

ff28b4b

…ts can still be unstable

shamardy merged commit 186bc95 into hd-account-balance Apr 22, 2024

shamardy deleted the evm-hd-wallet branch April 22, 2024 23:45

Conversation

shamardy commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artemii235 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

artemii235 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

artemii235 left a comment

Choose a reason for hiding this comment

Uh oh!

shamardy commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laruh Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

shamardy Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shamardy commented Apr 8, 2024

Uh oh!

shamardy commented Apr 8, 2024

Uh oh!

laruh left a comment

Choose a reason for hiding this comment

Uh oh!

dimxy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shamardy commented Sep 29, 2023 •

edited

Loading

shamardy Apr 4, 2024 •

edited

Loading