Skip to content

HD Wallet implementation #1838

@ca333

Description

@ca333

The HD-Wallet implementation is flawed and does not align with the official BIP32/44 standards as we seem only incrementing / deriving on the address index level with a static (potentially config-derived?) account id.

https://github.com/KomodoPlatform/atomicDEX-API/blob/371595d6c0d322e677669544aa37ec6304140fe8/mm2src/crypto/src/standard_hd_path.rs#L18

expectation:

  • multi-wallet support on seed level where each seed = one wallet. (already supported)
  • multi-account support: each asset allows the creation of multiple accounts (for clean "purpose" isolation). i.e. If I create a new account, the account ID needs incremented.
  • multi-address support: each account can then have multiple addresses.
  • if I create a multi-account/address wallet on any other BIP32/44 wallet (Trezor, etc.) I expect to see the same pub-keys for all accounts/addresses as in the corresponding ADEX wallet (with same seed).
  • implementation needs to align with official BIP32/44 standards

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions