Skip to content

[release] v0.8.0#586

Merged
ca333 merged 297 commits intomasterfrom
dev
Jun 8, 2023
Merged

[release] v0.8.0#586
ca333 merged 297 commits intomasterfrom
dev

Conversation

@ca333
Copy link
Copy Markdown

@ca333 ca333 commented May 30, 2023

changelog placehodler

@jmjatlanta
comment komodo_validate_interest
9eb2eb1
@jmjatlanta
Document globals in komodo_globals.h
e8735fe
@jmjatlanta
Switch to assetchain class
69dc615
@jmjatlanta
reformat help msgs
2ba0a9d
@jmjatlanta
properly initialize event_pubkeys
255153d
@jmjatlanta
Document crosschain
1faaf68
@jmjatlanta
Document Checkpoints
ef80962
@jmjatlanta
Clean up importcoin
c2c1b2b
@jmjatlanta
Document MakeCodaImportTx
f1d9d5c
@jmjatlanta
Add alert tests
42859e5
@jmjatlanta
fix pub key
bc97c3b
@jmjatlanta
Merge branch 'jmj_test_cleanup' into jmj_testutils
037d902
@jmjatlanta
Remove temp file
948988c
@jmjatlanta
properly shutdown tests
bae9e3a
@jmjatlanta
Move zcash tests to komodo
324a3dd
@jmjatlanta
serialize block header size test
fad7afb
@jmjatlanta
mempool tests
42bec82
@jmjatlanta
PoW tests
6e1257d
@jmjatlanta
PoW min difficulty test
defe10d
@jmjatlanta
Remove unnecessary header
6a331b8
@jmjatlanta
add txid tests
58aeb73
@jmjatlanta
Add coin_tests
abe48f6
@jmjatlanta
Begin tests of ConnectBlock
e8d9f80
@jmjatlanta
fix for running all tests
432c57f
@jmjatlanta
make static adjustable for unit testing
e46aae1
@jmjatlanta
Merge branch 'jmj_build_fix' into jmj_testutils
399f9fb
@jmjatlanta
More ConnectBlock tests
fc14310
@jmjatlanta
fix mempool nullptr
528d8f6
@jmjatlanta
Replace ptr with ref
16291af
@jmjatlanta
test double-spend in same block
cfe4608
DeckerSU and others added 15 commits May 25, 2023 17:26
@DeckerSU
reduce AUR 5% -> 0.01% after nS7HardforkHeight
3f7d055 
https://github.com/KomodoPlatform/kips/blob/main/kip-0001.mediawiki

TODO: don't forget to change 7113400 to nS7HardforkHeight, after
date of S7 HF will be determined.
@DeckerSU
change unit-tests releted to komodo interest reduce
e2e97b2
@DeckerSU
update DEPRECATION_HEIGHT to 4320000 (S8 approximated time + extra)
3d74ae9
@DeckerSU
update actual KIP-0001 heights to nS7HardforkHeight
d36c24d
@DeckerSU
Error handling improvements.
46c237a 
- DeckerSU/KomodoOcean@f7d014d
- DeckerSU/KomodoOcean@52334a6
@DeckerSU
Declare CBlockTreeDB::Read* methods as const when they are trivially so.
3115f20 
DeckerSU/KomodoOcean@1f981a8
@DeckerSU
txdb: get rid of consistency checks
688de60 
Details:

DeckerSU/KomodoOcean@24eaf1e
@Alrighttt
Merge pull request #42 from DeckerSU/patch-add-error-handling
bf0b713 
error handling improvements + get rid of consistency checks
@ca333
[ca333] update S7 key
b416d47
@ca333
Merge pull request #580 from DeckerSU/patch-mac-sleep
fb141ab 
remove debug sleep on darwin platform
@DeckerSU
Merge branch 's7-pubkeys' of git@github.com:KomodoPlatform/komodo.git…
64efc07 
… into patch-kip-0001
@ca333
Merge pull request #585 from KomodoPlatform/s7-pubkeys
1ac4453 
Add S7 pubkeys and HF estimate
@ca333
bump version [0.8.0]
35da539
@ca333
bump (min) protocol version
e94c666
@ca333
Merge pull request #584 from DeckerSU/patch-kip-0001
ac466df 
reduce AUR 5% -> 0.01% after nS7HardforkHeight
@ca333 ca333 requested review from Alrighttt, DeckerSU, dimxy and smk762 May 30, 2023 06:41
@dimxy
Copy link
Copy Markdown
Collaborator

dimxy commented May 30, 2023

There is a test TestNotary.KomodoNotaries which needs to be updated for the new season (it checks new timestamp and pubkeys).
I will add it in a new branch. Do we merge it now or later after the hardfork?

@DeckerSU
Copy link
Copy Markdown

DeckerSU commented May 30, 2023

Seems we missed #582. We should include it before HF, i guess, as we already mentioned hardware requirements for NNs based on Equihash solutions memory optimizations, introduced in #582. This PR also includes additional error checking and performance optimizations, like boost node startup time, etc.

dimxy and others added 3 commits May 30, 2023 22:47
dimxy
dimxy approved these changes Jun 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dimxy dimxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the new interest calculation, fixed tests for getting S7 pubkeys, all tests now work.
So it LGTM.
Probably we are short of time for publishing this release so let's do this ASAP.
I will continue testing though

DeckerSU
DeckerSU approved these changes Jun 8, 2023
View reviewed changes
Copy link
Copy Markdown

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The tests for HF simulation, among others, were passed successfully, making the product ready for use on the mainnet.

p.s. I will also keep carrying out tests on the HF simulation network.

@ca333 ca333 merged commit 156dba6 into master Jun 8, 2023
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jun 22, 2025
@Asherda
Merge pull request GLEECBTC#586 from Asherda/release-v1.2.4-2
f526b64 
Release v1.2.4-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimxy dimxy dimxy approved these changes

@DeckerSU DeckerSU DeckerSU approved these changes

@smk762 smk762 Awaiting requested review from smk762

@Alrighttt Alrighttt Awaiting requested review from Alrighttt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ca333 @dimxy @DeckerSU @jmjatlanta @tonymorony @smk762 @Alrighttt