Conversation
|
I looked over generate_nn_social.py and wonder why is for average block time estimation a depth equal to the blocks count till the planned hardfork used? Why not just take average for some rather long past period, like the whole year? |
I can do it over a longer period, though thought that more recent blocks may have a greater weight for recent conditions. I'll do a few more time frames to see how it compares. Its a "new" algo - in the past I believe a simple assumed 1 block per minute was used, but last year due to slow block production it was inaccurate. Since then production has stabilised (we added some things in last years HF to help). I was actually surprised to see the average over the last 6 weeks was pretty close to 60 sec, only 2 extra seconds. |
Maybe good to compare with the same period before the past hardfork |
|
Double checked that there were no errors in any of the keys submitted via: |
|
Checked blocktimes over the last 360 days alongside each 30 day slice within that timeframe. Open to any other methods or suggestions. |
|
Considering the fact that block generation is more stable this season, |
DeckerSU
left a comment
There was a problem hiding this comment.
LGTM.
After merge this PR, we also need to merge #584 , it's already rebased on s7-pubkeys branch, and contains all needed pubkeys / constants changes.
p.s. KomodoOcean codebase also will have all of our S7 related changes cherry-picked in the https://github.com/DeckerSU/KomodoOcean/tree/patch-s7 branch.
Release v1.2.4-1
Harvested via https://github.com/KomodoPlatform/NotaryNodes/blob/master/season7/elected_nn_social.json
Hardfork block estimate calculated with https://github.com/KomodoPlatform/NotaryNodes/blob/master/utils/generate_nn_social.py#L208-L227