Skip to content

Remove Coins and Cleanup#266

Merged
ca333 merged 66 commits intoGLEECBTC:devfrom
himu007:master
Jan 18, 2020
Merged

Remove Coins and Cleanup#266
ca333 merged 66 commits intoGLEECBTC:devfrom
himu007:master

Conversation

@himu007
Copy link
Copy Markdown

@himu007 himu007 commented Jan 14, 2020

Coins Removed:

Cleaned up files that are not needed longer

  • GLXT
  • BEER
  • PIZZA
  • ILIEN - it was from the first PR. they changed ticker to ILN and iln file is still present
  • MNZ
  • VOTE2018
  • VOTE2019
  • MGNX

himu007 and others added 30 commits October 1, 2018 10:53
* add dpow to BEER, fix crashed node not being able to sync due to future checkpoints.

* add extr print for new fix

* fix wallet corruption fix, for staking chains, fix forced rescan for ZEX and KMD with ztx in wallet.
* change to prices_getbetinfo()

* corr isRekt set

* new line

* Inital commit for prices fee to be paid to payments snapshot plan.

* change to work for all contracts

* fix RPC for airdrop, change to intake addresses instead of scriptpubkeys.

* prepare tokens airdrop

* fix pricesbet

* add utxos to paymentsinfo

* tokens airdrop RPC

* fix

* try this

* fixed reindex

* fix payments release

* fix reindex

* fix getaddresstxids help

* syntax

* fix payments allocation for alright

* Try to fix allocations

* prints

* remove ZEX, add ZEXO

* Fix paymentsCC, add skipminimum to validation and paymentsrelease

* change snapshot allocations to function

* revert labs exemption

* revert short reorg limit. Add some comments to dailysnapshot

* added protection from corrupted old version targetSymbol

* corr check for corrupt val

* returned isprint check

* +print

* Tiptime

* +print

* http

* https

* Verbose

* -debug

* fix payments balance

* fix paymentsmerge

* remove MGNX coin

* fix crash

* Test staking preformance improvement

* Fix KMD lockup on pools, try new fix electrum crash.

* fix

* bit safer

* Prevent linkability analysis on out-of-sync nodes

This addresses upstream issue zcash#3996
by preventing z_sendmany, z_mergecoinbase and z_shieldcoinbase from
making shielded transactions if the node is out of sync. This prevents
metadata leakage which can be used in blockchain analysis.

* Add synced key to getinfo+getblockchaininfo

This addresses #3 of upstream issue
zcash#3996 .

Any software that creates a transaction outside of the RPC interface
MUST check if synced==true beforehand, otherwise metadata leakage which
leads to linkability analysis is possible.

The z_sendmany, z_shieldcoinbase and z_mergetoaddress RPCs have their
own synced checks, so it's not needed to look at this new synced value
when using those RPCs.

* fix

* try staker fix

* add address to txidopret

* -extern

* revert build things for start.sh

* fix

* Update README.md

* change notary pubkey activation code.

* fix staking wallet fix.

* fix erase expired tx on wallet load

* fix erase expired tx on wallet load

* try fix

* change oraclessamples to obj

* remove print, remove unused obj

* Default bind

* add K64

* add K64

* Wait to look at KOMODO_INSYNC until we hold cs_main lock, to prevent a datarace when using chainActive

* fix PIRATE

* Update pubkey

* disable tokens funcID for now.

* revert labs build changes

* updated addr and pubkey

* update pub

* Activation on jul 15/1444000

* undo

* Ignore a.out

* Adjust for network header

* Ignores

* added totals to PriceGetOrderbook

* corr vobj

* logging book vars

* corr tx list selection

* commented logging to speed up

* more logging commented out

* added totalfund logging

* add endl

* added txid to log

* added isopen to pricesinfo

* added orderbooks to result

* corr isopposite
corr put into map

* corr store in map

* corr more put into map

* extra stmt removed

* added more totals

* corr calc

* corr totals calc

* added lev position calc

* changed back bet.positionsize calc

* returned back err check

* corr errcode check in syntheticprice

* isup pos flag added

* corr isup calc

* logging added

* more loggin

* test

* test

* added check amount acceptable

* corr check amount and lev in pricebet

* logging added

* more logging

* corr logic expr

* added check amount for 10%

* added > 5342 height

* corr height

* added check amount for addbet rpc

* added logging

* init uninited total vars

* logic expr optimized
logging added

* corr final opret

* corr opreturn check

* added funcid to switch

* corr validation code for 'R'

* corr final funcid

* corr total calc for cashout

* added position to orderbook output

* add vout with test revshare fee

* corr test scriptpubkey

* corr test scriptpubkey

* corr macro calc revshare fee

* added dust check

* corr add funding tx validation
added amount check

* test 77 3 chain param

* remove temp nk 77 3

* test removed

* test removed

* changed non validating height

* corr log msg

* earlytxid scriptpubkey vout enabled
validation enabled

* disable check for min revshare

* daywindow set to 7

* added refillfund rpc

* corr rpc help

* restored PRICES_DAYWINDOW to original

* added default err report in info

* removed base chain height

* daywindow = 7

* payments CC changes (#6)

* add oracles non-final oracle changes

* undo stuff

* fixes

* bug fixes paymentsinfo, getCCopret

* prepare tokens airdrop

* fix pricesbet

* add utxos to paymentsinfo

* tokens airdrop RPC

* fix

* try this

* fix payments release

* fix reindex

* fix getaddresstxids help

* syntax

* fix payments allocation for alright

* Try to fix allocations

* prints

* Fix paymentsCC, add skipminimum to validation and paymentsrelease

* change snapshot allocations to function

* revert labs exemption

* revert short reorg limit. Add some comments to dailysnapshot

* fix payments balance

* set PRICES_DAYWINDOW to orig

* corr bet and add tx validation
added min margin

* corr liq price calc

* added zero prices err code

* logging added for cb

* corr start scan h

* removed extra logging

* corr isrekt to true for'R' funcid

* returned scan chain for finalized for getinfo to work

* added check for isrekt set by final tx

* updated rekt fee calculation

* logging added

* added lastprice to orderbook print

* corr rekt fee for big leverages

* added pow to rekt txid

* simplified rekt hash check

* added validation for rekt txid

* remove rekt txid validation

* Update notaries_staked.h

Adding PHBA2061's publey & address

* osx: switch to gcc-8 static build

* kill RCTEST, update pubkeys

* fix CrisF

* change blackjoker

* fix

* update

* update

* change Alright key

* fix

* fix

* min sig =7, and change iguana port

* komodo-cli, wallet-utility and komodo-tx also need static build on OSX

* Update README.md to use gcc@8 on OSX

* Revert "komodo-cli, wallet-utility and komodo-tx also need static build on OSX"

This reverts commit a2a0cd2.

* osx: komodo-cli binary static libgcc linking

* fix notaryname in getinfo?

* last_notarized_height to getrawtransaction

* fix

* undo build changes
@kolobus
Copy link
Copy Markdown

kolobus commented Jan 14, 2020

Gathering confirmations, please wait

@kolobus
Copy link
Copy Markdown

kolobus commented Jan 14, 2020

Checking BNTN, EQL, PRLPAY, DION to add to this commit
Others confirmed

Copy link
Copy Markdown

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some coins not yet mentioned in comments are included in changes.
GLXT, BEER, PIZZA, ILIEN, MNZ, VOTE2018, VOTE2019, MGNX.
As far as I am aware, these are also obsoleted.

@@ -1,3 +0,0 @@
#!/bin/bash
./komodo-cli -ac_name=ILN $1 $2 $3 $4 $5 $6

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who do we remove it here and not in other places?

@@ -1,3 +0,0 @@
#!/bin/bash
./komodo-cli -ac_name=ILN $1 $2 $3 $4 $5 $6
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who do we remove it here and not in other places?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are 2 files, ilien & iln. ilien is just 1 file which represents ILN. And, iln file is still in there.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thank you! have not noticed that there is another file for this AC

Copy link
Copy Markdown

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of ilien files doesn't seems correct if to compare with this PR KomodoPlatform/dPoW#30

@kolobus
Copy link
Copy Markdown

kolobus commented Jan 15, 2020

Please merge in a current state with CEAL CHAIN COMMOD DSEC KMDICE and other fixes will go into next PR.

kolobus
kolobus previously approved these changes Jan 15, 2020
@himu007
Copy link
Copy Markdown
Author

himu007 commented Jan 15, 2020

Removal of ilien files doesn't seems correct if to compare with this PR KomodoPlatform/dPoW#30

Do you want to keep both ilien & iln in there?

@tonymorony tonymorony self-requested a review January 15, 2020 11:49
tonymorony
tonymorony previously approved these changes Jan 15, 2020
@ca333
Copy link
Copy Markdown

ca333 commented Jan 15, 2020

Please merge in a current state with CEAL CHAIN COMMOD DSEC KMDICE and other fixes will go into next PR.

what are waiting for to push these changes into the current PR?

Copy link
Copy Markdown

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR missing few more potential removals - plz evaluate situation and add those to this PR

@himu007
Copy link
Copy Markdown
Author

himu007 commented Jan 15, 2020

PR missing few more potential removals - plz evaluate situation and add those to this PR

How about we remove these first and then look for new ones? Stats count already stopped for these coins and we are just waiting for the PR to be merged to restart iguana to reflect these changes.
@kolobus also mentioned similar #266 (comment)

@ca333
Copy link
Copy Markdown

ca333 commented Jan 16, 2020

PR missing few more potential removals - plz evaluate situation and add those to this PR

How about we remove these first and then look for new ones? Stats count already stopped for these coins and we are just waiting for the PR to be merged to restart iguana to reflect these changes.
@kolobus also mentioned similar #266 (comment)

we are just waiting for the PR to be merged to restart iguana

No offence - I believe the discord update announcement was overhasty. The actual plan was to finish a code-review, remove dead coins (completing this PR), clean out some more obsoleted code, prepare HUSH3 upgrade and 3P migration and then announce one clean update for early coming week - that would give NNs 1 full week to update their nodes before HUSH upgrade activates. Multiple updates in such a small timeframe are suboptimal and lead to confusion. And forcing an incomplete PR to be merged due to a premature announcement likely resulting in a suboptimal situation as well.

I quickly checked the missing coins from #266 (comment) - we can remove those:

BNTN: dPoW unpaid; website dead (https://blocnation.io); no contact person available
EQL: dead; https://discordapp.com/channels/412898016371015680/455787938673065984
PRLPAY: dPoW unpaid; website dead (https://www.pearlpay.io/); no contact person available
DION: dPoW unpaid; chain moved to EOS according to Zilla; website and social media inactive since 2018 (https://twitter.com/dionpay , http://dionpay.com/)

@ca333 ca333 dismissed stale reviews from tonymorony and kolobus January 16, 2020 15:53

The base branch was changed.

@ca333 ca333 changed the base branch from master to dev January 16, 2020 15:53
@ca333 ca333 requested review from ca333, smk762 and tonymorony January 16, 2020 16:55
@ca333 ca333 merged commit 9e3b6cd into GLEECBTC:dev Jan 18, 2020
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants