Skip to content

Remove Coins from dPoW#30

Merged
ca333 merged 15 commits intoKomodoPlatform:devfrom
himu007:master
Jan 16, 2020
Merged

Remove Coins from dPoW#30
ca333 merged 15 commits intoKomodoPlatform:devfrom
himu007:master

Conversation

@himu007
Copy link
Copy Markdown
Contributor

@himu007 himu007 commented Jan 14, 2020 •
edited
Loading

Coins Removed:

  • CEAL - No longer needed. Confirmed by ca333
  • CHAIN - No longer needed. Confirmed by Jorian
  • COMMOD - dPoW expired and not renewed. Confirmed by ca333
  • DSEC - No longer needed. Confirmed by ca333
  • KMDICE - No longer needed. There will be a new dice CC module to replace this. Confirmed by Jorian

The following coins were removed after this comment from @ca333 GLEECBTC/komodo-daemon#266 (comment)

@jorian
Copy link
Copy Markdown

jorian commented Jan 14, 2020

CHAIN is dead, has no purpose anymore, it can be removed from dPoW.

smk762
smk762 reviewed Jan 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional coins removed in this commit not yet mentioned in comments. As far as I am aware they are also obsoleted.
HUSH (not HUSH3), MGNX, MNZ, MVP, PIZZA, SHARK, VOTE, VOTE2018.

@himu007 himu007 mentioned this pull request Jan 15, 2020
Merged
ca333
ca333 requested changes Jan 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete and few other coins removal being evaluated - plz include these coins in this PR.

@ca333
Copy link
Copy Markdown
Contributor

ca333 commented Jan 16, 2020

GLEECBTC/komodo-daemon#266 (comment)

@kolobus
Copy link
Copy Markdown
Contributor

kolobus commented Jan 16, 2020

Do not remove any coins but initial before agreed on their stats removal with me.
Initial coins 5 removal should be merged in as soon as possible.

Task wasn’t global all coins clean up in a single commit, but only coins where stats done.

@himu007
Copy link
Copy Markdown
Contributor Author

himu007 commented Jan 16, 2020 •
edited
Loading

Do not remove any coins but initial before agreed on their stats removal with me.
Initial coins 5 removal should be merged in as soon as possible.

Task wasn’t global all coins clean up in a single commit, but only coins where stats done.

@kolobus I added those coins after @ca333 made a comment here GLEECBTC/komodo-daemon#266 (comment)

@kolobus
Copy link
Copy Markdown
Contributor

kolobus commented Jan 16, 2020

@himu007 those can’t be merged before stats for them stopped in all places

@ca333
Copy link
Copy Markdown
Contributor

ca333 commented Jan 16, 2020

@himu007 those can’t be merged before stats for them stopped in all places

this is totally independent of some central websites fancy charts and stats - it will be merged after review.

@ca333 ca333 changed the base branch from master to dev January 16, 2020 16:55
@tonymorony tonymorony self-requested a review January 16, 2020 17:46
@ca333 ca333 merged commit a5e76b8 into KomodoPlatform:dev Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ca333 ca333 ca333 approved these changes

@kolobus kolobus Awaiting requested review from kolobus

@smk762 smk762 Awaiting requested review from smk762

+1 more reviewer

@tonymorony tonymorony tonymorony approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@himu007 @jorian @ca333 @kolobus @tonymorony @smk762 @3cl1ps