More protection against breaking the demo#2
Merged
Alkarex merged 1 commit intoFreshRSS:mainfrom Jul 7, 2025
Merged
Conversation
Member
Author
|
Changing UserJS or UserCSS should also be disallowed on |
Alkarex
pushed a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Jul 7, 2025
Related: FreshRSS/xExtension-Demo#2, #7559 (comment) Mostly to make sure that no one is able to break the demo instance But the issues below could possibly be exploited in other scenarios too: * Setting a theme like `../../lib/core-extensions/UserJS`: this directory contains `metadata.json` like themes do, so FreshRSS treats it as a theme after setting it and doesn't load any CSS * Setting a theme like `x dropdown-menu`: the `dropdown-menu` class was able to get injected into the `<body>` element since #7559 and turn every page blank
Member
|
Ping @marienfressinaud |
Member
Author
|
Member
|
Thanks! I just fixed the demo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallow changing the authentication method in
authControllerso that this doesn't happen:I took the screenshot yesterday, and today it's still broken: https://demo.freshrss.org
And I also realized that the
demouser can be modified by calling other actions instead, so that's now fixed inuserController.