Skip to content

Merge HTTP headers from cURL options#33

Merged
Alkarex merged 1 commit intofreshrssfrom
merge-curl-http-headers
Mar 5, 2025
Merged

Merge HTTP headers from cURL options#33
Alkarex merged 1 commit intofreshrssfrom
merge-curl-http-headers

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Mar 5, 2025

The $curl_options parameter could override the CURLOPT_HTTPHEADER option, so make sure to merge the HTTP headers properly.
Before this patch, providing an additional HTTP header via $curl_options[CURLOPT_HTTPHEADER] would remove all essential headers such as Accept, if-modified-since, etc.

The `$curl_options` parameter could override the `CURLOPT_HTTPHEADER` option, so make sure to merge the HTTP headers properly
@Alkarex
Copy link
Member Author

Alkarex commented Mar 5, 2025

Upstream PR simplepie#912

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Mar 5, 2025
fix FreshRSS#6712 (comment)
We would sometimes wrongly override the default HTTP headers of SimplePie
FreshRSS/simplepie#33
simplepie/simplepie#912
@Alkarex Alkarex merged commit d7e513f into freshrss Mar 5, 2025
20 checks passed
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Mar 5, 2025
Alkarex added a commit to FreshRSS/FreshRSS that referenced this pull request Mar 5, 2025
* Fix regression cURL HTTP headers
fix #6712 (comment)
We would sometimes wrongly override the default HTTP headers of SimplePie
FreshRSS/simplepie#33
simplepie/simplepie#912

* Sync SimplePie
FreshRSS/simplepie#33
@Alkarex Alkarex deleted the merge-curl-http-headers branch March 15, 2025 10:10
Sh4kE added a commit to Sh4kE/freshrss-helm-chart that referenced this pull request Mar 15, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [freshrss/freshrss](https://freshrss.org/) ([source](https://github.com/FreshRSS/FreshRSS)) | patch | `1.26.0-alpine` -> `1.26.1-alpine` |

---

### Release Notes

<details>
<summary>FreshRSS/FreshRSS (freshrss/freshrss)</summary>

### [`v1.26.1`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-03-13-FreshRSS-1261)

[Compare Source](FreshRSS/FreshRSS@1.26.0...1.26.1)

-   Features
    -   Add cURL version to page about system information [#&#8203;7409](FreshRSS/FreshRSS#7409)
-   Bug fixing
    -   Fix regression with cURL HTTP headers breaking conditional HTTP requests [#&#8203;7403](FreshRSS/FreshRSS#7403), [FreshRSS/simplepie#33](FreshRSS/simplepie#33)
    -   Fix regression with saving states of user queries [#&#8203;7400](FreshRSS/FreshRSS#7400)
    -   Fix regression with dynamic OPML [#&#8203;7394](FreshRSS/FreshRSS#7394)
    -   Fix update of the user’s last activity on login action [#&#8203;7406](FreshRSS/FreshRSS#7406)
    -   Fix setting category option *Maximum number of articles to keep per feed* [#&#8203;7416](FreshRSS/FreshRSS#7416)
    -   Fix priority field when processing a new feed from an extension [#&#8203;7354](FreshRSS/FreshRSS#7354)
-   Deployment
    -   Fix regression with 64-bit timestamps on 32-bit platforms [#&#8203;7375](FreshRSS/FreshRSS#7375)
    -   Fix back-compatibility with cURL 7.51 (we require cURL 7.52+ for `CURLPROXY_HTTPS`) [#&#8203;7409](FreshRSS/FreshRSS#7409)
-   UI
    -   Use case-insensitive sort for categories [#&#8203;7402](FreshRSS/FreshRSS#7402)
    -   Improve dark mode of *Origine* theme [#&#8203;7413](FreshRSS/FreshRSS#7413)
    -   Added API password indicator [#&#8203;7340](FreshRSS/FreshRSS#7340)
-   I18n
    -   Fix (es, fa, sk): do not translate XPath code [#&#8203;7404](FreshRSS/FreshRSS#7404)
    -   Fix date bug in Finish [#&#8203;7423](FreshRSS/FreshRSS#7423)
    -   Add Portuguese from Portugal [#&#8203;7329](FreshRSS/FreshRSS#7329)
    -   Improve Hungarian [#&#8203;7391](FreshRSS/FreshRSS#7391)
-   Misc.
    -   Improve PHP code [#&#8203;7339](FreshRSS/FreshRSS#7339)
    -   Update dev dependencies [#&#8203;7386](FreshRSS/FreshRSS#7386), [#&#8203;7387](FreshRSS/FreshRSS#7387), [#&#8203;7388](FreshRSS/FreshRSS#7388)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM5LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://gitea.sh4ke.rocks/lickler/freshrss/pulls/35
Co-authored-by: Michael Wittig <michael.wittig@posteo.de>
Co-committed-by: Michael Wittig <michael.wittig@posteo.de>
Sh4kE added a commit to Sh4kE/freshrss-helm-chart that referenced this pull request Mar 15, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [freshrss](https://github.com/FreshRSS/FreshRSS) | patch | `1.26.0` -> `1.26.1` |

---

### Release Notes

<details>
<summary>FreshRSS/FreshRSS (freshrss)</summary>

### [`v1.26.1`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-03-13-FreshRSS-1261)

[Compare Source](FreshRSS/FreshRSS@1.26.0...1.26.1)

-   Features
    -   Add cURL version to page about system information [#&#8203;7409](FreshRSS/FreshRSS#7409)
-   Bug fixing
    -   Fix regression with cURL HTTP headers breaking conditional HTTP requests [#&#8203;7403](FreshRSS/FreshRSS#7403), [FreshRSS/simplepie#33](FreshRSS/simplepie#33)
    -   Fix regression with saving states of user queries [#&#8203;7400](FreshRSS/FreshRSS#7400)
    -   Fix regression with dynamic OPML [#&#8203;7394](FreshRSS/FreshRSS#7394)
    -   Fix update of the user’s last activity on login action [#&#8203;7406](FreshRSS/FreshRSS#7406)
    -   Fix setting category option *Maximum number of articles to keep per feed* [#&#8203;7416](FreshRSS/FreshRSS#7416)
    -   Fix priority field when processing a new feed from an extension [#&#8203;7354](FreshRSS/FreshRSS#7354)
-   Deployment
    -   Fix regression with 64-bit timestamps on 32-bit platforms [#&#8203;7375](FreshRSS/FreshRSS#7375)
    -   Fix back-compatibility with cURL 7.51 (we require cURL 7.52+ for `CURLPROXY_HTTPS`) [#&#8203;7409](FreshRSS/FreshRSS#7409)
-   UI
    -   Use case-insensitive sort for categories [#&#8203;7402](FreshRSS/FreshRSS#7402)
    -   Improve dark mode of *Origine* theme [#&#8203;7413](FreshRSS/FreshRSS#7413)
    -   Added API password indicator [#&#8203;7340](FreshRSS/FreshRSS#7340)
-   I18n
    -   Fix (es, fa, sk): do not translate XPath code [#&#8203;7404](FreshRSS/FreshRSS#7404)
    -   Fix date bug in Finish [#&#8203;7423](FreshRSS/FreshRSS#7423)
    -   Add Portuguese from Portugal [#&#8203;7329](FreshRSS/FreshRSS#7329)
    -   Improve Hungarian [#&#8203;7391](FreshRSS/FreshRSS#7391)
-   Misc.
    -   Improve PHP code [#&#8203;7339](FreshRSS/FreshRSS#7339)
    -   Update dev dependencies [#&#8203;7386](FreshRSS/FreshRSS#7386), [#&#8203;7387](FreshRSS/FreshRSS#7387), [#&#8203;7388](FreshRSS/FreshRSS#7388)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM5LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://gitea.sh4ke.rocks/lickler/freshrss/pulls/37
Co-authored-by: Michael Wittig <michael.wittig@posteo.de>
Co-committed-by: Michael Wittig <michael.wittig@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant