Fix: Properly set the priority field when saving a new feed by EricDiao · Pull Request #7354 · FreshRSS/FreshRSS

EricDiao · 2025-02-23T02:09:09Z

Background:

I am writing a extension solely for my personal need: not putting entries feeds in a category in my main stream.

For that, I am hooking into the feed_before_insert hook and set the priority field to 0 (so that it only appear in its category).

But I find the priority does not change after doing so (but I tested all other fields including website etc is working). After dig into the source code of FeedDAO.php, I find that the priority field (unlike others) is missing from the values passed to addFeed so comes the proposed patch to solve this issue.

Changes proposed in this pull request:

Pass the priority field of FreshRSS_Feed object into the addFeed method of FreshRSS_FeedDAO properly so that the priority of a feed is properly set when a feed is added.

How to test the feature manually:

Hook into the feed_before_insert hook in an extension and change the priority to value other than the default (10);
Add a feed with the extension enabled.
Observe the difference before and after the patch applied:
- Before, the patch the priority field will be 10, the default value;
- After, the field is correctly set;

A minimal extension that tests the feature is

<?php

final class MuteExtension extends Minz_Extension
{
    #[\Override]
    public function init(): void
    {
        $this->registerHook('feed_before_insert', [$this, 'hook_feed_before_insert']);
    }

    public function hook_feed_before_insert(FreshRSS_Feed $feed): FreshRSS_Feed
    {
        $feed->_priority(0);
        $feed->_attribute('priority', 0); // Should be either or?

        return $feed;
    }
}

Pull request checklist:

clear commit messages
code manually tested
~~- [ ] unit tests written (optional if too hard)~~
~~- [ ] documentation updated~~

Additional information can be found in the documentation.

Signed-off-by: Zihao Diao <hi@ericdiao.com>

Alkarex · 2025-02-23T15:35:44Z

Thanks 👍🏻
Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

Alkarex · 2025-02-23T15:36:35Z

P.S. No, this line should be deleted ~~$feed->_attribute('priority', 0);~~

Signed-off-by: Zihao Diao <hi@ericdiao.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [freshrss/freshrss](https://freshrss.org/) ([source](https://github.com/FreshRSS/FreshRSS)) | patch | `1.26.0-alpine` -> `1.26.1-alpine` | --- ### Release Notes <details> <summary>FreshRSS/FreshRSS (freshrss/freshrss)</summary> ### [`v1.26.1`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-03-13-FreshRSS-1261) [Compare Source](FreshRSS/FreshRSS@1.26.0...1.26.1) - Features - Add cURL version to page about system information [#7409](FreshRSS/FreshRSS#7409) - Bug fixing - Fix regression with cURL HTTP headers breaking conditional HTTP requests [#7403](FreshRSS/FreshRSS#7403), [FreshRSS/simplepie#33](FreshRSS/simplepie#33) - Fix regression with saving states of user queries [#7400](FreshRSS/FreshRSS#7400) - Fix regression with dynamic OPML [#7394](FreshRSS/FreshRSS#7394) - Fix update of the user’s last activity on login action [#7406](FreshRSS/FreshRSS#7406) - Fix setting category option *Maximum number of articles to keep per feed* [#7416](FreshRSS/FreshRSS#7416) - Fix priority field when processing a new feed from an extension [#7354](FreshRSS/FreshRSS#7354) - Deployment - Fix regression with 64-bit timestamps on 32-bit platforms [#7375](FreshRSS/FreshRSS#7375) - Fix back-compatibility with cURL 7.51 (we require cURL 7.52+ for `CURLPROXY_HTTPS`) [#7409](FreshRSS/FreshRSS#7409) - UI - Use case-insensitive sort for categories [#7402](FreshRSS/FreshRSS#7402) - Improve dark mode of *Origine* theme [#7413](FreshRSS/FreshRSS#7413) - Added API password indicator [#7340](FreshRSS/FreshRSS#7340) - I18n - Fix (es, fa, sk): do not translate XPath code [#7404](FreshRSS/FreshRSS#7404) - Fix date bug in Finish [#7423](FreshRSS/FreshRSS#7423) - Add Portuguese from Portugal [#7329](FreshRSS/FreshRSS#7329) - Improve Hungarian [#7391](FreshRSS/FreshRSS#7391) - Misc. - Improve PHP code [#7339](FreshRSS/FreshRSS#7339) - Update dev dependencies [#7386](FreshRSS/FreshRSS#7386), [#7387](FreshRSS/FreshRSS#7387), [#7388](FreshRSS/FreshRSS#7388) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.sh4ke.rocks/lickler/freshrss/pulls/35 Co-authored-by: Michael Wittig <michael.wittig@posteo.de> Co-committed-by: Michael Wittig <michael.wittig@posteo.de>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [freshrss](https://github.com/FreshRSS/FreshRSS) | patch | `1.26.0` -> `1.26.1` | --- ### Release Notes <details> <summary>FreshRSS/FreshRSS (freshrss)</summary> ### [`v1.26.1`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-03-13-FreshRSS-1261) [Compare Source](FreshRSS/FreshRSS@1.26.0...1.26.1) - Features - Add cURL version to page about system information [#7409](FreshRSS/FreshRSS#7409) - Bug fixing - Fix regression with cURL HTTP headers breaking conditional HTTP requests [#7403](FreshRSS/FreshRSS#7403), [FreshRSS/simplepie#33](FreshRSS/simplepie#33) - Fix regression with saving states of user queries [#7400](FreshRSS/FreshRSS#7400) - Fix regression with dynamic OPML [#7394](FreshRSS/FreshRSS#7394) - Fix update of the user’s last activity on login action [#7406](FreshRSS/FreshRSS#7406) - Fix setting category option *Maximum number of articles to keep per feed* [#7416](FreshRSS/FreshRSS#7416) - Fix priority field when processing a new feed from an extension [#7354](FreshRSS/FreshRSS#7354) - Deployment - Fix regression with 64-bit timestamps on 32-bit platforms [#7375](FreshRSS/FreshRSS#7375) - Fix back-compatibility with cURL 7.51 (we require cURL 7.52+ for `CURLPROXY_HTTPS`) [#7409](FreshRSS/FreshRSS#7409) - UI - Use case-insensitive sort for categories [#7402](FreshRSS/FreshRSS#7402) - Improve dark mode of *Origine* theme [#7413](FreshRSS/FreshRSS#7413) - Added API password indicator [#7340](FreshRSS/FreshRSS#7340) - I18n - Fix (es, fa, sk): do not translate XPath code [#7404](FreshRSS/FreshRSS#7404) - Fix date bug in Finish [#7423](FreshRSS/FreshRSS#7423) - Add Portuguese from Portugal [#7329](FreshRSS/FreshRSS#7329) - Improve Hungarian [#7391](FreshRSS/FreshRSS#7391) - Misc. - Improve PHP code [#7339](FreshRSS/FreshRSS#7339) - Update dev dependencies [#7386](FreshRSS/FreshRSS#7386), [#7387](FreshRSS/FreshRSS#7387), [#7388](FreshRSS/FreshRSS#7388) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.sh4ke.rocks/lickler/freshrss/pulls/37 Co-authored-by: Michael Wittig <michael.wittig@posteo.de> Co-committed-by: Michael Wittig <michael.wittig@posteo.de>

fix: properly set the priority field of feeds when adding new feed.

466d4b7

Signed-off-by: Zihao Diao <hi@ericdiao.com>

Alkarex added the Extension 🔌 label Feb 23, 2025

Alkarex added this to the 1.26.0 milestone Feb 23, 2025

Alkarex added the Bug (confirmed) 🐞 issues that are reproducible label Feb 23, 2025

Alkarex modified the milestones: 1.26.0, 1.27.0 Feb 23, 2025

Alkarex merged commit b0b75dd into FreshRSS:edge Feb 23, 2025
1 check passed

EricDiao added a commit to EricDiao/FreshRSS that referenced this pull request Feb 23, 2025

add my name to CREDITS.md after FreshRSS#7354

78fa42d

Signed-off-by: Zihao Diao <hi@ericdiao.com>

EricDiao mentioned this pull request Feb 23, 2025

Add my name to CREDITS.md after #7354 #7358

Merged

1 task

Alkarex pushed a commit that referenced this pull request Feb 24, 2025

add my name to CREDITS.md after #7354 (#7358)

9430498

Signed-off-by: Zihao Diao <hi@ericdiao.com>

Alkarex modified the milestones: 1.27.0, 1.26.1 Mar 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Properly set the priority field when saving a new feed#7354

Fix: Properly set the priority field when saving a new feed#7354
Alkarex merged 1 commit intoFreshRSS:edgefrom
EricDiao:ericdiao/feed-add-priority

EricDiao commented Feb 23, 2025

Uh oh!

Uh oh!

Alkarex commented Feb 23, 2025

Uh oh!

Alkarex commented Feb 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

EricDiao commented Feb 23, 2025

Uh oh!

Uh oh!

Alkarex commented Feb 23, 2025

Uh oh!

Alkarex commented Feb 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants