Fixes for frss.css by Inverle · Pull Request #7616 · FreshRSS/FreshRSS

Inverle · 2025-05-25T15:50:53Z

Fixes for frss.css
- It wasn't possible to scroll fully to the bottom in aside menu and configure menu on mobile (moved from CSS fixes for Swage #7608)
- Align text on expandable sections to the left on mobile (moved from CSS fixes for Swage #7608)
- ~~Show not-allowed cursor on disabled buttons instead of a pointer (moved from CSS fixes for Swage #7608)~~
- Wrap text in search dropdown for mobile
- Fixed page overflowing on mobile in feed settings
Named some elements with IDs in nav_menu.phtml to make them easier selectable in Swage (moved from CSS fixes for Swage #7608)

Inverle · 2025-05-25T15:57:04Z

Navigation buttons in anonymous view

After (actualize button is shown too of course, when enabled):

Before:

How they usually look when signed in:

Alkarex · 2025-05-28T08:20:06Z

Any comment on the CSS @math-GH ?

p/themes/base-theme/frss.css

math-GH · 2025-05-30T13:39:45Z

Any comment on the CSS @math-GH ?

will do it.
There are some changes that needs more investigation to understand the impact on all other themes.

A comment regarding showing more buttons:
In general (it is not the fault of this PR): It will be more visible now that there are "read" and "unread" articles. The user can read but cannot mark an article as read. It could be confusing to have a articles that the user read 1 minute ago is still marked as "unread". The "read/unread" icon of each article will not be displayed in the anonymous view. So the reader could not understand which articles are "read" or "unread". Similar to the "stared" articles.

If there are no user queries: what will be displayed in the dropdown in the anonymous view? With this PR it will be an empty dropdown list (because the "add query" list item will no be displayed).

I understand the idea behind this PR but it will make the UX (currently) worse instead of better.

(review of frss.css will follow later)

Inverle · 2025-06-13T19:00:13Z

@math-GH any updates? also #7608

It will be more visible now that there are "read" and "unread" articles. The user can read but cannot mark an article as read. It could be confusing to have a articles that the user read 1 minute ago is still marked as "unread"

Not a problem, as long as the user understands they're in anonymous view.
(though I understand it could be confusing)

The "read/unread" icon of each article will not be displayed in the anonymous view. So the reader could not understand which articles are "read" or "unread". Similar to the "stared" articles.

I think this is obvious there's one unread article in this screenshot and one starred?

If there are no user queries: what will be displayed in the dropdown in the anonymous view? With this PR it will be an empty dropdown list (because the "add query" list item will no be displayed).

I wouldn't say that this is an empty dropdown list, but it could be improved (maybe it could say No user queries similar to the My labels menu?)

math-GH · 2025-06-16T20:31:35Z

@math-GH any updates? also #7608

It will be more visible now that there are "read" and "unread" articles. The user can read but cannot mark an article as read. It could be confusing to have a articles that the user read 1 minute ago is still marked as "unread"

Not a problem, as long as the user understands they're in anonymous view. (though I understand it could be confusing)

I would say that the "anonymous view" is used mostly by non registered users. It means they do not have any experiences with the system. The UI and UX should be understandable without any experiences.

The "read/unread" icon of each article will not be displayed in the anonymous view. So the reader could not understand which articles are "read" or "unread". Similar to the "stared" articles.

I think this is obvious there's one unread article in this screenshot and one starred?

IMHO each article should have its own read/unread icon to show its status.
The background color should not be used as only markup. There are users with low contrast view (people with color disability, people with low contrast screens or low light screens etc)

Articles could starred and read/unread. Starred overrides the read/unread color (in Origine theme. I did not check the other themes)

If there are no user queries: what will be displayed in the dropdown in the anonymous view? With this PR it will be an empty dropdown list (because the "add query" list item will no be displayed).

I wouldn't say that this is an empty dropdown list, but it could be improved (maybe it could say No user queries similar to the My labels menu?)

It is just the title line now. I would suggest to hide the User Query button if there is no User Query.

Inverle · 2025-06-29T10:33:14Z

@math-GH

I would say that the "anonymous view" is used mostly by non registered users. It means they do not have any experiences with the system. The UI and UX should be understandable without any experiences.

You're right. I reverted these changes, I may work on this later.

The PR has only CSS changes now.

Alkarex · 2025-07-05T21:19:32Z

Now there is a little PR conflict

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [freshrss/freshrss](https://freshrss.org/) ([source](https://github.com/FreshRSS/FreshRSS)) | minor | `1.26.3` -> `1.27.0` | --- ### Release Notes <details> <summary>FreshRSS/FreshRSS (freshrss/freshrss)</summary> ### [`v1.27.0`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-08-18-FreshRSS-1270) [Compare Source](FreshRSS/FreshRSS@1.26.3...1.27.0) - Features - Implement support for HTTP `429 Too Many Requests` and `503 Service Unavailable`, obey `Retry-After` [#7760](FreshRSS/FreshRSS#7760) - Add sort by category title, or by feed title [#7702](FreshRSS/FreshRSS#7702) - Add search operator `c:` for categories like `c:23,34` or `!c:45,56` [#7696](FreshRSS/FreshRSS#7696) - Custom feed favicons [#7646](FreshRSS/FreshRSS#7646), [#7704](FreshRSS/FreshRSS#7704), [#7717](FreshRSS/FreshRSS#7717), [#7792](FreshRSS/FreshRSS#7792) - Rework fetch favicons for fewer HTTP requests [#7767](FreshRSS/FreshRSS#7767) - Add more unicity criteria based on title and/or content [#7789](FreshRSS/FreshRSS#7789) - Automatically restore user configuration from backup [#7682](FreshRSS/FreshRSS#7682) - API add support for states in `s` parameter of `streamId` [#7695](FreshRSS/FreshRSS#7695) - Improve sharing via Print [#7728](FreshRSS/FreshRSS#7728) - Redirect to the login page from bookmarklet instead of 403 [#7782](FreshRSS/FreshRSS#7782) - Clean local cache more often, when refreshing feeds [#7827](FreshRSS/FreshRSS#7827) - Security - Implement reauthentication (*sudo* mode) [#7753](FreshRSS/FreshRSS#7753) - Add `Content-Security-Policy: frame-ancestors` [#7677](FreshRSS/FreshRSS#7677) - Ensure CSP everywhere [#7810](FreshRSS/FreshRSS#7810) - Show warning when unsafe CSP policy is in use [#7804](FreshRSS/FreshRSS#7804) - Fix access rights when creating a new user [#7783](FreshRSS/FreshRSS#7783) - Improve security of form for user details [#7771](FreshRSS/FreshRSS#7771), [#7786](FreshRSS/FreshRSS#7786) - Disallow setting non-existent theme [#7722](FreshRSS/FreshRSS#7722) - Regenerate cookie ID after logging out [#7762](FreshRSS/FreshRSS#7762) - Require current password when setting new password [#7763](FreshRSS/FreshRSS#7763) - Add missing access checks for feed-related actions [#7768](FreshRSS/FreshRSS#7768) - Strip more unsafe attributes such as `referrerpolicy`, `ping` [#7770](FreshRSS/FreshRSS#7770) - Remove unneeded execution permissions [#7802](FreshRSS/FreshRSS#7802) - Bug fixing - Fix redirections when scraping from HTML [#7654](FreshRSS/FreshRSS#7654), [#7741](FreshRSS/FreshRSS#7741) - Fix multiple authentication HTTP headers [#7703](FreshRSS/FreshRSS#7703) - Fix HTML queries with a single feed [#7730](FreshRSS/FreshRSS#7730) - WebSub: only perform a redirection when coming from WebSub [#7738](FreshRSS/FreshRSS#7738) - Include enclosures in entries’ hash [#7719](FreshRSS/FreshRSS#7719) - Negative side-effect: users of the option to *automatically mark updated articles as unread* will once have some articles with enclosures re-appear as unread - Fix cancellation of slider exit UI [#7705](FreshRSS/FreshRSS#7705) - Honor *disable update* on update page [#7733](FreshRSS/FreshRSS#7733) - Fix no registration limit setting [#7751](FreshRSS/FreshRSS#7751) - Fix XML encoding of sharing functions [#7822](FreshRSS/FreshRSS#7822) - SimplePie - Fix propagation of HTTP error codes [#7670](FreshRSS/FreshRSS#7670) - Fix support for XML feeds with HTML entities [#7689](FreshRSS/FreshRSS#7689), [simplepie#915](simplepie/simplepie#915) - Fix feeds encoded in UTF-16LE [#7691](FreshRSS/FreshRSS#7691), [simplepie#916](simplepie/simplepie#916) - Various upstream contributions [simplepie#917](simplepie/simplepie#917), [simplepie#924](simplepie/simplepie#924), [simplepie#926](simplepie/simplepie#926), [simplepie#932](simplepie/simplepie#932), [simplepie#933](simplepie/simplepie#933) - Sync upstream [#7706](FreshRSS/FreshRSS#7706), [FreshRSS/simplepie#45](FreshRSS/simplepie#45), [#7775](FreshRSS/FreshRSS#7775), [FreshRSS/simplepie#50](FreshRSS/simplepie#50), [#7824](FreshRSS/FreshRSS#7824), [#7825](FreshRSS/FreshRSS#7825), - Fix regex *Backtrack limit was exhausted* in `clean_hash()` [#7813](FreshRSS/FreshRSS#7813), [FreshRSS/simplepie#48](FreshRSS/simplepie#48) - Deployment - Docker default image (Debian 12 Bookworm) updated to PHP 8.2.29 [#7805](FreshRSS/FreshRSS#7805) - Docker alternative image updated to Alpine 3.22 with PHP 8.4.11 and Apache 2.4.65 [#7740](FreshRSS/FreshRSS#7740), [#7740](FreshRSS/FreshRSS#7740), [#7803](FreshRSS/FreshRSS#7803) - Start supporting PHP 8.5+ [#7787](FreshRSS/FreshRSS#7787), [#7826](FreshRSS/FreshRSS#7826) - Docker Alpine dev image `:newest` updated to PHP 8.5-alpha and Apache 2.4.65 [#7773](FreshRSS/FreshRSS#7773) - Docker: interpolate `FRESHRSS_INSTALL` and `FRESHRSS_USER` variables [#7725](FreshRSS/FreshRSS#7725) - Docker: Reduce how much data needs to be chown/chmod’ed on container startup [#7793](FreshRSS/FreshRSS#7793) - Test for database PDO typing support during install (relevant for MySQL / MariaDB with obsolete driver) [#7651](FreshRSS/FreshRSS#7651) - Extensions - Add API endpoint for extensions [#7576](FreshRSS/FreshRSS#7576) - Expose the reading modes for extensions [#7668](FreshRSS/FreshRSS#7668), [#7688](FreshRSS/FreshRSS#7688) - New extension hook `before_login_btn` [#7761](FreshRSS/FreshRSS#7761) - UI - Improve *mark as read* request showing popup due to `onbeforeunload` [#7554](FreshRSS/FreshRSS#7554) - Fix lazy-loading for `<video poster="...">` and `<image>` [#7636](FreshRSS/FreshRSS#7636) - Avoid styling `<code>` inside of `<pre>` [#7797](FreshRSS/FreshRSS#7797) - Improve confirmation logic with `data-auto-leave-validation` [#7785](FreshRSS/FreshRSS#7785) - Update `chart.js` to 4.5.0 [#7752](FreshRSS/FreshRSS#7752), [#7816](FreshRSS/FreshRSS#7816) - Various UI and style improvements: [#7616](FreshRSS/FreshRSS#7616), [#7811](FreshRSS/FreshRSS#7811) - I18n - Show translation status in README [#7715](FreshRSS/FreshRSS#7715) - Improve Indonesian [#7654](FreshRSS/FreshRSS#7654), [#7721](FreshRSS/FreshRSS#7721) - Improve Persian [#7795](FreshRSS/FreshRSS#7795) - Misc. - Improve PHP code [#7642](FreshRSS/FreshRSS#7642), [#7665](FreshRSS/FreshRSS#7665), [#7761](FreshRSS/FreshRSS#7761), [#7781](FreshRSS/FreshRSS#7781), [#7794](FreshRSS/FreshRSS#7794) - Update dev dependencies [#7708](FreshRSS/FreshRSS#7708), [#7709](FreshRSS/FreshRSS#7709), [#7710](FreshRSS/FreshRSS#7710), [#7711](FreshRSS/FreshRSS#7711), [#7776](FreshRSS/FreshRSS#7776), [#7777](FreshRSS/FreshRSS#7777) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1253 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Fixes for frss.css and make more buttons accessible in anonymous view

3621551

Inverle mentioned this pull request May 25, 2025

CSS fixes for Swage #7608

Merged

Alkarex added this to the 1.26.3 milestone May 25, 2025

Alkarex added the UI 🎨 User Interfaces label May 25, 2025

Alkarex approved these changes May 28, 2025

View reviewed changes

Frenzie reviewed May 28, 2025

View reviewed changes

p/themes/base-theme/frss.css Outdated Show resolved Hide resolved

Frenzie reviewed May 28, 2025

View reviewed changes

p/themes/base-theme/frss.css Outdated Show resolved Hide resolved

Inverle added 2 commits May 28, 2025 16:42

Suggested changes and page overflow fix

c5f0562

Forgot rtlcss

b71f875

Frenzie approved these changes May 28, 2025

View reviewed changes

Alkarex modified the milestones: 1.26.3, 1.27.0 Jun 1, 2025

Inverle mentioned this pull request Jun 6, 2025

Implement custom feed favicons #7646

Merged

Inverle added 2 commits June 29, 2025 12:04

Merge branch 'edge' into ui-fixes

4f72fe9

Revert anonymous view changes

7365a50

Inverle changed the title ~~Fixes for frss.css and make more buttons accessible in anonymous view~~ Fixes for frss.css Jun 29, 2025

Merge branch 'edge' into ui-fixes

a0703ec

Alkarex merged commit edda6f0 into FreshRSS:edge Jul 16, 2025
1 check passed

Inverle deleted the ui-fixes branch December 6, 2025 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes for frss.css#7616

Fixes for frss.css#7616
Alkarex merged 6 commits intoFreshRSS:edgefrom
Inverle:ui-fixes

Inverle commented May 25, 2025 •

edited

Loading

Uh oh!

Inverle commented May 25, 2025

Uh oh!

Alkarex commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

math-GH commented May 30, 2025

Uh oh!

Inverle commented Jun 13, 2025 •

edited

Loading

Uh oh!

math-GH commented Jun 16, 2025

Uh oh!

Inverle commented Jun 29, 2025

Uh oh!

Alkarex commented Jul 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Inverle commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Inverle commented May 25, 2025

Uh oh!

Alkarex commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

math-GH commented May 30, 2025

Uh oh!

Inverle commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

math-GH commented Jun 16, 2025

Uh oh!

Inverle commented Jun 29, 2025

Uh oh!

Alkarex commented Jul 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Inverle commented May 25, 2025 •

edited

Loading

Inverle commented Jun 13, 2025 •

edited

Loading