Fix mark as read request showing popup due to onbeforeunload by Inverle · Pull Request #7554 · FreshRSS/FreshRSS

Inverle · 2025-05-05T05:46:11Z

Fixes #7410 (introduced in 4b1a2cc)

Uses visibilitychange event instead of onbeforeunload
Refactors send_mark_read_queue to use fetch()

p/scripts/main.js

Alkarex · 2025-05-05T06:22:39Z

Decreasing the interval can be discussed, but the negative side is that more HTTP requests are sent, spending more resources both client side (thing e.g. battery and data consumption) as well as server side (think e.g. rate limits).
The other return false is by design, as I have explained a bit higher up - does it make sense?

Inverle · 2025-05-05T07:43:16Z

Decreasing the interval can be discussed, but the negative side is that more HTTP requests are sent, spending more resources both client side (thing e.g. battery and data consumption) as well as server side (think e.g. rate limits). The other return false is by design, as I have explained a bit higher up - does it make sense?

Okay, thanks for your input, do you think 8a8f395 is a better solution?
This solution also makes sure that the entries are marked as read, when the user leaves the page, but without showing a popup.
I have set the interval back to 1000.

p/scripts/main.js

…nd_mark_read_queue to use fetch

p/scripts/main.js

Alkarex · 2025-07-05T21:41:52Z

p/scripts/main.js

+		keepalive: true
+	}).then(resp => {
+		if (!resp.ok) {
+			return Promise.reject(resp);


Checking the support for the Fetch API and for async/await, I think the two are close enough that we should jump to the much cleaner async/await style.
That is to say try ... await fetch() ... throw resp; ... await resp.json() ... catch...
Would you feel like giving it a try?

Yes, I'll do that.

I should make mark_favorite and labels request also use fetch(..., {keepalive: true}), right?

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [freshrss/freshrss](https://freshrss.org/) ([source](https://github.com/FreshRSS/FreshRSS)) | minor | `1.26.3` -> `1.27.0` | --- ### Release Notes <details> <summary>FreshRSS/FreshRSS (freshrss/freshrss)</summary> ### [`v1.27.0`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-08-18-FreshRSS-1270) [Compare Source](FreshRSS/FreshRSS@1.26.3...1.27.0) - Features - Implement support for HTTP `429 Too Many Requests` and `503 Service Unavailable`, obey `Retry-After` [#7760](FreshRSS/FreshRSS#7760) - Add sort by category title, or by feed title [#7702](FreshRSS/FreshRSS#7702) - Add search operator `c:` for categories like `c:23,34` or `!c:45,56` [#7696](FreshRSS/FreshRSS#7696) - Custom feed favicons [#7646](FreshRSS/FreshRSS#7646), [#7704](FreshRSS/FreshRSS#7704), [#7717](FreshRSS/FreshRSS#7717), [#7792](FreshRSS/FreshRSS#7792) - Rework fetch favicons for fewer HTTP requests [#7767](FreshRSS/FreshRSS#7767) - Add more unicity criteria based on title and/or content [#7789](FreshRSS/FreshRSS#7789) - Automatically restore user configuration from backup [#7682](FreshRSS/FreshRSS#7682) - API add support for states in `s` parameter of `streamId` [#7695](FreshRSS/FreshRSS#7695) - Improve sharing via Print [#7728](FreshRSS/FreshRSS#7728) - Redirect to the login page from bookmarklet instead of 403 [#7782](FreshRSS/FreshRSS#7782) - Clean local cache more often, when refreshing feeds [#7827](FreshRSS/FreshRSS#7827) - Security - Implement reauthentication (*sudo* mode) [#7753](FreshRSS/FreshRSS#7753) - Add `Content-Security-Policy: frame-ancestors` [#7677](FreshRSS/FreshRSS#7677) - Ensure CSP everywhere [#7810](FreshRSS/FreshRSS#7810) - Show warning when unsafe CSP policy is in use [#7804](FreshRSS/FreshRSS#7804) - Fix access rights when creating a new user [#7783](FreshRSS/FreshRSS#7783) - Improve security of form for user details [#7771](FreshRSS/FreshRSS#7771), [#7786](FreshRSS/FreshRSS#7786) - Disallow setting non-existent theme [#7722](FreshRSS/FreshRSS#7722) - Regenerate cookie ID after logging out [#7762](FreshRSS/FreshRSS#7762) - Require current password when setting new password [#7763](FreshRSS/FreshRSS#7763) - Add missing access checks for feed-related actions [#7768](FreshRSS/FreshRSS#7768) - Strip more unsafe attributes such as `referrerpolicy`, `ping` [#7770](FreshRSS/FreshRSS#7770) - Remove unneeded execution permissions [#7802](FreshRSS/FreshRSS#7802) - Bug fixing - Fix redirections when scraping from HTML [#7654](FreshRSS/FreshRSS#7654), [#7741](FreshRSS/FreshRSS#7741) - Fix multiple authentication HTTP headers [#7703](FreshRSS/FreshRSS#7703) - Fix HTML queries with a single feed [#7730](FreshRSS/FreshRSS#7730) - WebSub: only perform a redirection when coming from WebSub [#7738](FreshRSS/FreshRSS#7738) - Include enclosures in entries’ hash [#7719](FreshRSS/FreshRSS#7719) - Negative side-effect: users of the option to *automatically mark updated articles as unread* will once have some articles with enclosures re-appear as unread - Fix cancellation of slider exit UI [#7705](FreshRSS/FreshRSS#7705) - Honor *disable update* on update page [#7733](FreshRSS/FreshRSS#7733) - Fix no registration limit setting [#7751](FreshRSS/FreshRSS#7751) - Fix XML encoding of sharing functions [#7822](FreshRSS/FreshRSS#7822) - SimplePie - Fix propagation of HTTP error codes [#7670](FreshRSS/FreshRSS#7670) - Fix support for XML feeds with HTML entities [#7689](FreshRSS/FreshRSS#7689), [simplepie#915](simplepie/simplepie#915) - Fix feeds encoded in UTF-16LE [#7691](FreshRSS/FreshRSS#7691), [simplepie#916](simplepie/simplepie#916) - Various upstream contributions [simplepie#917](simplepie/simplepie#917), [simplepie#924](simplepie/simplepie#924), [simplepie#926](simplepie/simplepie#926), [simplepie#932](simplepie/simplepie#932), [simplepie#933](simplepie/simplepie#933) - Sync upstream [#7706](FreshRSS/FreshRSS#7706), [FreshRSS/simplepie#45](FreshRSS/simplepie#45), [#7775](FreshRSS/FreshRSS#7775), [FreshRSS/simplepie#50](FreshRSS/simplepie#50), [#7824](FreshRSS/FreshRSS#7824), [#7825](FreshRSS/FreshRSS#7825), - Fix regex *Backtrack limit was exhausted* in `clean_hash()` [#7813](FreshRSS/FreshRSS#7813), [FreshRSS/simplepie#48](FreshRSS/simplepie#48) - Deployment - Docker default image (Debian 12 Bookworm) updated to PHP 8.2.29 [#7805](FreshRSS/FreshRSS#7805) - Docker alternative image updated to Alpine 3.22 with PHP 8.4.11 and Apache 2.4.65 [#7740](FreshRSS/FreshRSS#7740), [#7740](FreshRSS/FreshRSS#7740), [#7803](FreshRSS/FreshRSS#7803) - Start supporting PHP 8.5+ [#7787](FreshRSS/FreshRSS#7787), [#7826](FreshRSS/FreshRSS#7826) - Docker Alpine dev image `:newest` updated to PHP 8.5-alpha and Apache 2.4.65 [#7773](FreshRSS/FreshRSS#7773) - Docker: interpolate `FRESHRSS_INSTALL` and `FRESHRSS_USER` variables [#7725](FreshRSS/FreshRSS#7725) - Docker: Reduce how much data needs to be chown/chmod’ed on container startup [#7793](FreshRSS/FreshRSS#7793) - Test for database PDO typing support during install (relevant for MySQL / MariaDB with obsolete driver) [#7651](FreshRSS/FreshRSS#7651) - Extensions - Add API endpoint for extensions [#7576](FreshRSS/FreshRSS#7576) - Expose the reading modes for extensions [#7668](FreshRSS/FreshRSS#7668), [#7688](FreshRSS/FreshRSS#7688) - New extension hook `before_login_btn` [#7761](FreshRSS/FreshRSS#7761) - UI - Improve *mark as read* request showing popup due to `onbeforeunload` [#7554](FreshRSS/FreshRSS#7554) - Fix lazy-loading for `<video poster="...">` and `<image>` [#7636](FreshRSS/FreshRSS#7636) - Avoid styling `<code>` inside of `<pre>` [#7797](FreshRSS/FreshRSS#7797) - Improve confirmation logic with `data-auto-leave-validation` [#7785](FreshRSS/FreshRSS#7785) - Update `chart.js` to 4.5.0 [#7752](FreshRSS/FreshRSS#7752), [#7816](FreshRSS/FreshRSS#7816) - Various UI and style improvements: [#7616](FreshRSS/FreshRSS#7616), [#7811](FreshRSS/FreshRSS#7811) - I18n - Show translation status in README [#7715](FreshRSS/FreshRSS#7715) - Improve Indonesian [#7654](FreshRSS/FreshRSS#7654), [#7721](FreshRSS/FreshRSS#7721) - Improve Persian [#7795](FreshRSS/FreshRSS#7795) - Misc. - Improve PHP code [#7642](FreshRSS/FreshRSS#7642), [#7665](FreshRSS/FreshRSS#7665), [#7761](FreshRSS/FreshRSS#7761), [#7781](FreshRSS/FreshRSS#7781), [#7794](FreshRSS/FreshRSS#7794) - Update dev dependencies [#7708](FreshRSS/FreshRSS#7708), [#7709](FreshRSS/FreshRSS#7709), [#7710](FreshRSS/FreshRSS#7710), [#7711](FreshRSS/FreshRSS#7711), [#7776](FreshRSS/FreshRSS#7776), [#7777](FreshRSS/FreshRSS#7777) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1253 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Prevent onbeforeunload from showing a popup before leaving

f756e51

Alkarex reviewed May 5, 2025

View reviewed changes

p/scripts/main.js Show resolved Hide resolved

Send mark as read request when leaving and revert interval

8a8f395

Alkarex reviewed May 7, 2025

View reviewed changes

p/scripts/main.js Outdated Show resolved Hide resolved

Inverle added 2 commits May 7, 2025 21:13

Merge branch 'edge' into mark-read-fix

1eaa2c1

Use visibilitychange event instead of onbeforeunload, and refactor se…

200f1b0

…nd_mark_read_queue to use fetch

Inverle changed the title ~~Prevent onbeforeunload from showing a popup before leaving~~ Fix mark as read request showing popup due to onbeforeunload May 7, 2025

Inverle added 2 commits May 24, 2025 23:43

Merge branch 'edge' of github.com:Inverle/FreshRSS into mark-read-fix

4657f49

Merge branch 'edge' of github.com:Inverle/FreshRSS into mark-read-fix

cc13010

Inverle requested a review from Alkarex May 24, 2025 22:01

Alkarex reviewed May 31, 2025

View reviewed changes

p/scripts/main.js Show resolved Hide resolved

Alkarex added this to the 1.27.0 milestone May 31, 2025

Alkarex reviewed May 31, 2025

View reviewed changes

p/scripts/main.js Outdated Show resolved Hide resolved

Alkarex reviewed Jun 19, 2025

View reviewed changes

p/scripts/main.js Show resolved Hide resolved

Move removed code to the new catch block

bbf6870

Alkarex reviewed Jul 5, 2025

View reviewed changes

Inverle added 2 commits July 6, 2025 11:14

Merge branch 'edge' into mark-read-fix

19650fe

Refactor with async fetch

bee31ae

Alkarex merged commit 6744a2f into FreshRSS:edge Jul 16, 2025
1 check passed

Alkarex added UI 🎨 User Interfaces javascript Pull requests that update Javascript code labels Jul 16, 2025

Inverle deleted the mark-read-fix branch December 6, 2025 16:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix mark as read request showing popup due to onbeforeunload#7554

Fix mark as read request showing popup due to onbeforeunload#7554
Alkarex merged 9 commits intoFreshRSS:edgefrom
Inverle:mark-read-fix

Inverle commented May 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Alkarex commented May 5, 2025

Uh oh!

Inverle commented May 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alkarex Jul 5, 2025

Uh oh!

Inverle Jul 5, 2025

Uh oh!

Inverle Jul 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Inverle commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Alkarex commented May 5, 2025

Uh oh!

Inverle commented May 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alkarex Jul 5, 2025

Choose a reason for hiding this comment

Uh oh!

Inverle Jul 5, 2025

Choose a reason for hiding this comment

Uh oh!

Inverle Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Inverle commented May 5, 2025 •

edited

Loading

Inverle Jul 6, 2025 •

edited

Loading