Fix HTTP cache for modified time when content is not modified#6723
Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom Aug 19, 2024
Merged
Fix HTTP cache for modified time when content is not modified#6723Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex merged 1 commit intoFreshRSS:edgefrom
Conversation
Fix case when server is sending a new modified time while the content was not actually modified. fix FreshRSS#6712
Frenzie
approved these changes
Aug 19, 2024
Member
There was a problem hiding this comment.
I don't think that fixes the linked issue as such, even my hypothesis about Retry-After is incorrect. But no matter. this behavior is clearly better regardless. 👍
The feed in question had plenty of updates after all, so this particular condition would've occurred only very few times, unless it purposefully kept changing the Last-Modified constantly even without updates.
Member
Author
|
Indeed, this PR is not related to |
Member
Author
|
Will have to be re-implemented in #4374 , FreshRSS/simplepie#11 |
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Aug 19, 2024
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Sep 8, 2024
* Hash-based caching simplepie#401 FreshRSS/FreshRSS@9aab83a FreshRSS/FreshRSS@00127f0 * Backport fix FreshRSS/FreshRSS#6723 * A few fixes * Reduce changes * Reduce changes * Relax some tests * Fix comment * Fix a few tests * PHP 7.2 compatibility * Behaviour fixes * Simplification * Comment * Fix tests * Remove debug logs * Minor comment * Fix type mess with $this->data['headers']
Member
Author
|
Help welcome to test this PR #4374 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix case when server is sending a new modified time while the content was not actually modified.
fix #6712