Skip to content

Remove Referer header from SimplePie feed request#6523

Closed
willhbr wants to merge 1 commit intoFreshRSS:edgefrom
willhbr:willhbr/push-wpmunuxwvptp
Closed

Remove Referer header from SimplePie feed request#6523
willhbr wants to merge 1 commit intoFreshRSS:edgefrom
willhbr:willhbr/push-wpmunuxwvptp

Conversation

@willhbr
Copy link

@willhbr willhbr commented Jun 1, 2024

This seems unnecessary, and the equivalent behaviour was removed for other downloads in this PR.

@Alkarex
Copy link
Member

Alkarex commented Sep 14, 2024

Sorry for the delay, due to the refactoring of using SimplePie (big mess!) #4374
Our SimplePie fork is now maintained on https://github.com/FreshRSS/simplepie so feel free to resubmit there, or even better upstream https://github.com/simplepie/simplepie (but the upstream repo is very slow).
Regarding this PR, it would be nice to test with plenty of feeds. We have seen a bunch, which are sensitive to user-agent, cookies, and what not, which should in principle not be needed. I have not tested specifically for Referer recently though, but I would not be surprised to break some feeds by removing it.

@Alkarex Alkarex closed this Sep 14, 2024
@Alkarex Alkarex mentioned this pull request Sep 15, 2024
Closed
@Alkarex
Copy link
Member

Alkarex commented Sep 21, 2024

Custom HTTP headers added #6820
Ready to remove Referer

@Alkarex Alkarex added this to the 1.25.0 milestone Sep 21, 2024
@Alkarex
Copy link
Member

Alkarex commented Sep 21, 2024

#6811

Alkarex added a commit to FreshRSS/simplepie that referenced this pull request Sep 21, 2024
@Alkarex
Remove HTTP Referer
946ebd3 
FreshRSS/FreshRSS#6523
FreshRSS/FreshRSS#6811
@Alkarex Alkarex mentioned this pull request Sep 21, 2024
Merged
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Sep 21, 2024
@Alkarex
Remove HTTP Referer
aba8990 
FreshRSS/simplepie#27
FreshRSS#6523
fix FreshRSS#6811
simplepie/simplepie#224
@Alkarex Alkarex mentioned this pull request Sep 21, 2024
Merged
@Alkarex
Copy link
Member

Alkarex commented Sep 21, 2024

#6822

Alkarex added a commit to FreshRSS/simplepie that referenced this pull request Sep 21, 2024
@Alkarex
Remove HTTP Referer (#27)
e041dac 
FreshRSS/FreshRSS#6523
FreshRSS/FreshRSS#6811
Alkarex added a commit that referenced this pull request Sep 21, 2024
@Alkarex
Remove HTTP Referer (#6822)
7b2e87f 
* Remove HTTP Referer
FreshRSS/simplepie#27
#6523
fix #6811
simplepie/simplepie#224

* Bump SimplePie commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

SimplePie 🍰

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@willhbr @Alkarex