Skip to content

More PHP type hints for Fever#4202

Merged
Alkarex merged 2 commits intoFreshRSS:edgefrom
Alkarex:fever_more_type_hints
Feb 6, 2022
Merged

More PHP type hints for Fever#4202
Alkarex merged 2 commits intoFreshRSS:edgefrom
Alkarex:fever_more_type_hints

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Feb 6, 2022

Follow-up of #4201
Related to #4200

@Alkarex Alkarex added the API 🤝 API for other clients label Feb 6, 2022
@Alkarex Alkarex added this to the 1.20.0 milestone Feb 6, 2022
@Alkarex
Copy link
Member Author

Alkarex commented Feb 6, 2022

Merging to avoid conflicts with more changes coming

@Alkarex Alkarex merged commit 7c2da31 into FreshRSS:edge Feb 6, 2022
@Alkarex Alkarex deleted the fever_more_type_hints branch February 6, 2022 23:56
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Aug 20, 2022
Regression from FreshRSS#4202
> Warning: Declaration of FreshRSS_EntryDAOSQLite::markRead($ids, $is_read = true) should be compatible with FreshRSS_EntryDAO::markRead($ids, bool $is_read = true) in /var/www/FreshRSS/app/Models/EntryDAOSQLite.php on line 3
@Alkarex Alkarex mentioned this pull request Aug 20, 2022
Alkarex added a commit that referenced this pull request Aug 20, 2022
Regression from #4202
> Warning: Declaration of FreshRSS_EntryDAOSQLite::markRead($ids, $is_read = true) should be compatible with FreshRSS_EntryDAO::markRead($ids, bool $is_read = true) in /var/www/FreshRSS/app/Models/EntryDAOSQLite.php on line 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API 🤝 API for other clients

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant