Fix Fever 32 bit ID issue + more PHP type hints#4201
Merged
Alkarex merged 4 commits intoFreshRSS:edgefrom Feb 6, 2022
Merged
Conversation
#fix FreshRSS#4200 Follow up and fix regression from FreshRSS#4110
Alkarex
commented
Feb 6, 2022
Comment on lines
-488
to
+470
| $max_id = ctype_digit('' . $_REQUEST['max_id']) ? intval($_REQUEST['max_id']) : null; | ||
| $max_id = '' . $_REQUEST['max_id']; | ||
| if (!ctype_digit($max_id)) { | ||
| $max_id = null; | ||
| } | ||
| } elseif (isset($_REQUEST['with_ids'])) { | ||
| $entry_ids = explode(',', $_REQUEST['with_ids']); | ||
| } elseif (isset($_REQUEST['since_id'])) { | ||
| // use the since_id argument to request the next $item_limit items | ||
| $since_id = ctype_digit('' . $_REQUEST['since_id']) ? intval($_REQUEST['since_id']) : null; | ||
| $since_id = '' . $_REQUEST['since_id']; | ||
| if (!ctype_digit($since_id)) { | ||
| $since_id = null; | ||
| } |
Member
Author
There was a problem hiding this comment.
That is the most relevant par of the bug fix
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Feb 6, 2022
Follow-up of FreshRSS#4201 Related to FreshRSS#4200
Alkarex
added a commit
that referenced
this pull request
Feb 6, 2022
Alkarex
added a commit
that referenced
this pull request
Feb 28, 2022
* More PHP type hints for Fever Follow-up of #4201 Related to #4200 * Detail * Draft * Progress * More draft * Fix thumbnail PHP type hint #4215 * More types * A bit more * Refactor FreshRSS_Entry::fromArray * Progress * Starts to work * Categories * Fonctional * Layout update * Fix relative URLs * Cache system * Forgotten files * Remove a debug line * Automatic form validation of XPath expressions * data-leave-validation * Fix reload action * Simpler examples * Fix column type for PostgreSQL * Enforce HTTP encoding * Readme * Fix get full content * target="_blank" * gitignore * htmlspecialchars_utf8 * Implement HTML <base> And fix/revert `xml:base` support in SimplePie simplepie/simplepie@e49c578 * SimplePie upstream PR merged simplepie/simplepie#723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#fix #4200
Follow up and fix regression from #4110
Entry IDs need to be strings to work on 32-bit systems. There was an error due to enforced Int64 in the Fever API.