Skip to content

Fix regression user init#4116

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:fix-init
Jan 2, 2022
Merged

Fix regression user init#4116
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:fix-init

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Jan 2, 2022

#fix #4115
Bug introduced by #4021

@Alkarex Alkarex added this to the 1.19.1 milestone Jan 2, 2022
@Alkarex Alkarex merged commit a19b453 into FreshRSS:edge Jan 2, 2022
@Alkarex Alkarex deleted the fix-init branch January 2, 2022 17:19
@Alkarex
Copy link
Member Author

Alkarex commented Jan 2, 2022

Damn, I did not look carefully enough. The bug was only in edge, not in 1.19.0, so it was not a true regression...
So now I have made a hastily 1.19.1 point-release. My mistake. I hope it will not break something else 🤞🏻

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jan 2, 2022
@Alkarex Alkarex mentioned this pull request Jan 2, 2022
Alkarex added a commit that referenced this pull request Jan 4, 2022
* Fix most PHPDocs errors
Contributes to #4103
https://phpstan.org/writing-php-code/phpdoc-types

* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to #4103

* PHPStan level 3

* PHPStand level 4

* Update default to PHPStan level 4

* Towards level 5

* Fix level 4 regression

* Towards level 5

* Pass PHPStan level 5

* Towards level 6

* Remove erronenous regression from changelog
#4116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]Error during context user init!

1 participant