Merged
Conversation
#fix FreshRSS#4016 https://phpstan.org/ ```sh composer run-script phpstan ```
Member
Author
|
There are already a number of fixes to do to pass level 1, and then we can increase the rule-level for more https://phpstan.org/user-guide/rule-levels Help welcome in this PR already to pass level 1. I will then add it to our CI |
Frenzie
reviewed
Dec 3, 2021
Frenzie
approved these changes
Dec 3, 2021
Member
Frenzie
left a comment
There was a problem hiding this comment.
Looks like it should be fine, but didn't check in the closest detail. Definitely needs full testing.
Member
Author
|
(off-topic) @math-GH You should have received an email from me 📬 |
1 task
This was referenced Dec 31, 2021
Closed
This was referenced Dec 31, 2021
Merged
Merged
Alkarex
commented
Jan 2, 2022
|
|
||
| try { | ||
| $sql = $SQL_CREATE_TABLES . $SQL_CREATE_TABLE_ENTRYTMP . $SQL_CREATE_TABLE_TAGS; | ||
| $sql = $GLOBALS['$SQL_CREATE_TABLES'] . $GLOBALS['SQL_CREATE_TABLE_ENTRYTMP'] . $GLOBALS['SQL_CREATE_TABLE_TAGS']; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#fix #4016
https://phpstan.org/