SimplePie fix PHP8 uncatched error#3547
Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom Mar 23, 2021
Merged
Conversation
#fix FreshRSS#3546 When `loadHTML()` is given a null or empty string. ``` PHP Fatal error: Uncaught ValueError: DOMDocument::loadHTML(): Argument #1 ($source) must not be empty in /var/www/freshrss/lib/SimplePie/SimplePie/Locator.php:83 ```
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Mar 20, 2021
Fix ``` PHP Fatal error: Uncaught ValueError: DOMDocument::loadHTML(): Argument #1 ($source) must not be empty in /SimplePie/Locator.php:83 ``` `set_error_handler` does not catch ValueError in PHP8 The code is compatible PHP5 and PHP7. Fix downstream bug FreshRSS/FreshRSS#3537 Downstream PR FreshRSS/FreshRSS#3547
Member
Author
|
Patch submitted upstream simplepie/simplepie#673 |
mblaney
pushed a commit
to simplepie/simplepie
that referenced
this pull request
Mar 23, 2021
Fix ``` PHP Fatal error: Uncaught ValueError: DOMDocument::loadHTML(): Argument #1 ($source) must not be empty in /SimplePie/Locator.php:83 ``` `set_error_handler` does not catch ValueError in PHP8 The code is compatible PHP5 and PHP7. Fix downstream bug FreshRSS/FreshRSS#3537 Downstream PR FreshRSS/FreshRSS#3547
Member
Author
|
Accepted and merged upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#fix #3537
When
loadHTML()is given a null or empty string.