Skip to content

Fix undefined variable & dead code when adding feed#3546

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:fix-add-feed-cookie
Mar 21, 2021
Merged

Fix undefined variable & dead code when adding feed#3546
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:fix-add-feed-cookie

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Mar 20, 2021

Fix warning due to undefined $cookie variable. CURLOPT_COOKIE is not used when adding a feed.
Problem introduced in #3494

@Alkarex Alkarex added this to the 1.19.0 milestone Mar 20, 2021
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Mar 20, 2021
#fix FreshRSS#3546
When `loadHTML()` is given a null or empty string.

```
PHP Fatal error:  Uncaught ValueError: DOMDocument::loadHTML(): Argument #1 ($source) must not be empty in /var/www/freshrss/lib/SimplePie/SimplePie/Locator.php:83
```
@Alkarex Alkarex merged commit e2533bd into FreshRSS:edge Mar 21, 2021
@Alkarex Alkarex deleted the fix-add-feed-cookie branch March 21, 2021 11:23
Alkarex added a commit that referenced this pull request Mar 23, 2021
#fix #3546
When `loadHTML()` is given a null or empty string.

```
PHP Fatal error:  Uncaught ValueError: DOMDocument::loadHTML(): Argument #1 ($source) must not be empty in /var/www/freshrss/lib/SimplePie/SimplePie/Locator.php:83
```
@Alkarex Alkarex modified the milestones: 1.19.0, 1.18.1 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant