Skip to content

Fix API minor code syntax warning#2362

Merged
Alkarex merged 2 commits intoFreshRSS:devfrom
Alkarex:fix_api_warning
Apr 7, 2019
Merged

Fix API minor code syntax warning#2362
Alkarex merged 2 commits intoFreshRSS:devfrom
Alkarex:fix_api_warning

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Apr 7, 2019

#2359 (comment)
Caught by PHP lint from PHP 7.3+

@Alkarex Alkarex added this to the 1.14.2 milestone Apr 7, 2019
@Frenzie
Copy link
Member

Frenzie commented Apr 7, 2019

Do you suppose the output should be grepped for PHP Warning or some such? It's the only one, after all.

Edit: that is, I didn't see a command line option to make php -l unsuccessful in case of warnings.

@Alkarex
Copy link
Member Author

Alkarex commented Apr 7, 2019

I have just looked for the same :-)
It might be good indeed to alert a bit more for PHP lint warnings. Maybe an allowed fail if doable, or just a fail indeed if you can find a way to do that.

@Alkarex Alkarex merged commit d26a49b into FreshRSS:dev Apr 7, 2019
@Alkarex Alkarex deleted the fix_api_warning branch April 7, 2019 19:50
Frenzie added a commit to Frenzie/FreshRSS that referenced this pull request Apr 7, 2019
By redirecting stderr to a file and checking if the filesize is greater than 0 bytes, we can also force failure for warnings.

See discussion in <FreshRSS#2362 (comment)>.
Alkarex pushed a commit that referenced this pull request Apr 8, 2019
* [CI] Force php -l failure

By redirecting stderr to a file and checking if the filesize is greater than 0 bytes, we can also force failure for warnings.

See discussion in <#2362 (comment)>.

* exclude JSON lib
Alkarex added a commit that referenced this pull request Apr 8, 2019
@Alkarex Alkarex mentioned this pull request Apr 8, 2019
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* [CI] Force php -l failure

By redirecting stderr to a file and checking if the filesize is greater than 0 bytes, we can also force failure for warnings.

See discussion in <FreshRSS#2362 (comment)>.

* exclude JSON lib
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants