Conversation
By redirecting stderr to a file and checking if the filesize is greater than 0 bytes, we can also force failure for warnings. See discussion in <FreshRSS#2362 (comment)>.
|
I hadn't noticed this before. On the one hand I could exclude libraries (perhaps better on a case by case basis just so we are aware), on the other hand it's not completely clear to me what the library is for given the native |
|
The JSON library was for the infamous period when php_json was not included in the default PHP distribution on Debian due to a license problem :-/ |
|
And yes, I think third-party libraries should be excluded (and manually checked during inclusion / updates) |
|
Since they're all fine (except for that one) and it is good to be aware of it, I'd argue against a priori exclusion of third-party libraries. |
|
Btw, my local PHP 7.3.3 instance doesn't show this warning. Must be some php.ini setting? |
|
Maybe PHP 7.3.4 (e.g from https://hub.docker.com/_/php ) (I am on mobile atm). |
|
It's The way I wrote it now only libs/JSON is excluded, to which other files could be added if circumstances require it. The important thing is that it's a conscious decision imo. |
* [CI] Force php -l failure By redirecting stderr to a file and checking if the filesize is greater than 0 bytes, we can also force failure for warnings. See discussion in <FreshRSS#2362 (comment)>. * exclude JSON lib
By redirecting stderr to a file and checking if the filesize is greater than 0 bytes, we can also force failure for warnings.
See discussion in #2362 (comment).