Fix corePKCS11 demo build errors #719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moninom1
pushed a commit
to moninom1/FreeRTOS
that referenced
this pull request
Apr 17, 2023
* fixed cbmc proof for vSocketBind * Use CBMC XML output to enable VSCode debugger (FreeRTOS#673) Prior to this commit, CBMC would emit logging information in plain text format, which does not contain information required for the CBMC VSCode debugger. This commit makes CBMC use XML instead of plain text. Co-authored-by: Mark Tuttle <tuttle@acm.org> * fix cbmc proof for vSocketWakeUpUser * add check with multiple endpoints * NULL assume to assignment * adding non determinitic number of end points * adding commit review suggestions * Uncrustify: triggered by comment. --------- Co-authored-by: Kareem Khazem <karkhaz@amazon.com> Co-authored-by: Mark Tuttle <tuttle@acm.org> Co-authored-by: GitHub Action <action@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following demos do not build properly in the latest release:
Prior to the latest release, the demos had not been updated to be compatible with the changes to corePKCS11
FreeRTOS/corePKCS11#123
The two demos were importing "core_pkcs11_pal.h" from the path "corePKCS11\source\portable\windows", whereas corePKCS11 has updated the path to "corePKCS11\source\portable\os\freertos_winsim".
The demos are currently non-functioning, but updating the build files allows these demos to be added to the CI checks.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.