Fix typo in Japanese translation #2340
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-policy-service agree |
Member
|
Merged, thanks. If you're able to prepare a spearate PR that targets the |
musashi-miyamoto
pushed a commit
to musashi-miyamoto/FluentValidation
that referenced
this pull request
Oct 27, 2025
Backport from 12.x FluentValidation#2340
JeremySkinner
pushed a commit
that referenced
this pull request
Oct 28, 2025
Backport from 12.x #2340
Member
|
12.1.0 and 11.12.0 are now released with this change |
evgenygunko
added a commit
to evgenygunko/Translations
that referenced
this pull request
Nov 15, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentValidation](https://fluentvalidation.net/) ([source](https://github.com/JeremySkinner/fluentvalidation)) | nuget | minor | `12.0.0` -> `12.1.0` | | [HtmlAgilityPack](http://html-agility-pack.net/) ([source](https://github.com/zzzprojects/html-agility-pack)) | nuget | patch | `1.12.2` -> `1.12.4` | | [OpenAI](https://github.com/openai/openai-dotnet/tree/OpenAI_2.7.0) ([source](https://github.com/openai/openai-dotnet)) | nuget | minor | `2.3.0` -> `2.7.0` | | [Roslynator.Analyzers](https://github.com/dotnet/roslynator) | nuget | patch | `4.14.0` -> `4.14.1` | --- ### Release Notes <details> <summary>JeremySkinner/fluentvalidation (FluentValidation)</summary> ### [`v12.1.0`](https://github.com/FluentValidation/FluentValidation/releases/tag/12.1.0) [Compare Source](FluentValidation/FluentValidation@12.0.0...12.1.0) ### Release notes [Please read the upgrade guide if you are moving from 11.x to 12.x](https://docs.fluentvalidation.net/en/latest/upgrading-to-12.html) #### Changes in 12.1.0 - Add Tamil language ([#​2334](FluentValidation/FluentValidation#2334)) - Add Telugu language ([#​2333](FluentValidation/FluentValidation#2333)) - Fixes to Japanese translations ([#​2340](FluentValidation/FluentValidation#2340)) #### Changes in 12.0.0 - Drops support for netstandard2.0, netstandard2.1, .net 5, .net 6 and .net 7. Minimum supported platform is now .net 8. - Add support for dependent rules for custom rules ([#​2170](FluentValidation/FluentValidation#2170)) - Removes deprecated DI extensions - Removes deprecated transform methods ([#​2027](FluentValidation/FluentValidation#2027)) - Remove the ability to disable the root-model null check ([#​2069](FluentValidation/FluentValidation#2069)) - Use Zomp.SyncMethodGenerator to clean up internal sync/async code paths and increase performance ([#​2136](FluentValidation/FluentValidation#2136)) - Add Serbian (Cyrillic) language; rename existing Serbian to Serbian (Latin) ([#​2283](FluentValidation/FluentValidation#2283)) ### Downloads Binaries can be downloaded from nuget: - [FluentValidation](http://nuget.org/packages/fluentvalidation) - Main package </details> <details> <summary>zzzprojects/html-agility-pack (HtmlAgilityPack)</summary> ### [`v1.12.4`](https://github.com/zzzprojects/html-agility-pack/releases/tag/v1.12.4) ##### Download the library **[here](https://www.nuget.org/packages/HtmlAgilityPack/)** **ADDED:** New property `OriginalOuterLength` for OuterLength is incorrect, refering to the reconstructed OuterHtml and not the original [#​602](zzzprojects/html-agility-pack#602) **FIX...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request corrects a minor punctuation error in the Japanese translation for a validation message.
Before
'{PropertyName}' は '{ComparisonValue} 以上でなければなりません'.The closing quotation mark was incorrectly placed outside the sentence-ending punctuation.
After
'{PropertyName}' は '{ComparisonValue}' 以上でなければなりません。The sentence now ends correctly with a Japanese full stop inside the quotation marks.
Note
This issue also exists in older versions of the library.
I'm submitting this fix against the latest version, but if it's considered necessary for 11.x as well, I'm happy to prepare a corresponding PR.
Thank you.