Conversation
|
I re-implemented the verbose method as discussed in Delgan/loguru#192, so this should work properly now. |
|
I'll verify and merge |
44c62b0 to
055b43e
Compare
|
I ran |
gazpachoking
left a comment
There was a problem hiding this comment.
I'd avoid mixing in all the unrelated format changes into PRs in the future. makes it way harder to review the actual changes. Not too sure about the whole entry state enum, but not really against it either. We should perhaps move to using it in more places if it stays in.
Agreed on pre-commit, although I tried it on my work (windows) machine and it was not easy to get set up here. If I remember correctly, it went smoothly on my home windows machine, I'll add the pre-commit script when I get there and can test it properly. Also, maybe we should modify the autoformat dev tool to only run on files changed in the git working tree by default, and require some extra param to do everything. |
|
Yeah, I should have probably skipped yhecautoformats stuff but I saw that it didnt render the changes completely unreadable. |
…Flexget/Flexget into color_by_action � Conflicts: � flexget/components/tmdb/tmdb_lookup.py � flexget/components/trakt/trakt_calendar.py
|
@liiight I like that simple escaping solution. We can figure out a better way if we start coloring more stuff and need to. |
|
I agree. This was a bit trickier since we generically markup messages. I imagine that if we'd want to use this in a more specific use case it won't be an issue |
Motivation for changes:
It'd be nice to have some distinction in logs between accept/reject.
Detailed changes:
To Do: