Allow .opt() calls to be chained on loggers#193
Closed
gazpachoking wants to merge 1 commit intoDelgan:masterfrom
Closed
Allow .opt() calls to be chained on loggers#193gazpachoking wants to merge 1 commit intoDelgan:masterfrom
gazpachoking wants to merge 1 commit intoDelgan:masterfrom
Conversation
1 task
Owner
|
Closing due to discussions in #192. The documentation has been updated with a new workaround for custom levels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #192
Calling .opt() multiple times now keeps the options set on previous calls rather than setting all unspecified options back to their default.
Wasn't sure best how to make the test for this, so I just copied another one that used multiple options, and split it apart into 2
.opt()calls.