Skip to content

[Add] pending list batch operation and deletion endpoint#2535

Merged
kristenmills merged 5 commits intodevelopfrom
pending-list-batch
Dec 17, 2019
Merged

[Add] pending list batch operation and deletion endpoint#2535
kristenmills merged 5 commits intodevelopfrom
pending-list-batch

Conversation

@kristenmills
Copy link
Copy Markdown
Member

@kristenmills kristenmills commented Dec 17, 2019

Motivation for changes:

I'm adding some bulk operation features to webui (Flexget/webui#54) so this seemed better than making a lot of requests. Eventually I want to just make graphQL or gRPC endpoints for webui to use and these batch operations will be cleaner but that's a later activity.

Detailed changes:

  • Add new endpoint PUT /pending_list/{list_id}/entries/batch for bulk approving, rejecting pending list entries
  • Add new endpoint DELETE /pending_list/{list_id}/entries/batch for bulk removing removing pending list entries

@kristenmills kristenmills changed the title Pending list batch Add] pending list batch operation endpoint Dec 17, 2019
@kristenmills kristenmills changed the title Add] pending list batch operation endpoint [Add] pending list batch operation endpoint Dec 17, 2019
Copy link
Copy Markdown
Member

@paranoidi paranoidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restful idioms

@kristenmills kristenmills changed the title [Add] pending list batch operation endpoint [Add] pending list batch operation and deletion endpoint Dec 17, 2019
Copy link
Copy Markdown
Member

@liiight liiight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristenmills kristenmills dismissed paranoidi’s stale review December 17, 2019 18:24

we talked about it in slack

@kristenmills kristenmills merged commit cec873f into develop Dec 17, 2019
@kristenmills kristenmills deleted the pending-list-batch branch December 17, 2019 18:25
kristenmills added a commit that referenced this pull request Dec 17, 2019
Forgot to do this in  #2535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants