Skip to content

[Feature] Pending list bulk actions#54

Merged
kristenmills merged 16 commits intodevelopfrom
pending-list-bulk
Dec 17, 2019
Merged

[Feature] Pending list bulk actions#54
kristenmills merged 16 commits intodevelopfrom
pending-list-bulk

Conversation

@kristenmills
Copy link
Copy Markdown
Member

@kristenmills kristenmills commented Dec 16, 2019

Motivation for changes:

This will get pending list to a mostly functional state. probably will need some fast follows and cleanup later

Detailed changes:

  • inject toolbar into navbar
  • Support contextual app bar in pending list
  • Support Approve, Reject, remove and inject all
  • Updated card state when the item is selected.
  • Overflow Menu component
  • Move Add List and entry to a Fab

Addressed issues:

To Do:

@kristenmills kristenmills mentioned this pull request Dec 16, 2019
14 tasks
@kristenmills kristenmills marked this pull request as ready for review December 17, 2019 10:35
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2019

Codecov Report

Merging #54 into develop will decrease coverage by 3.72%.
The diff coverage is 13.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
- Coverage    63.05%   59.33%   -3.73%     
===========================================
  Files          106      110       +4     
  Lines         1551     1682     +131     
  Branches       223      248      +25     
===========================================
+ Hits           978      998      +20     
- Misses         572      683     +111     
  Partials         1        1
Impacted Files Coverage Δ
src/core/layout/styles.ts 100% <ø> (ø) ⬆️
src/core/api/index.ts 91.66% <ø> (+4.16%) ⬆️
src/plugins/pendingList/hooks/list.ts 0% <0%> (ø) ⬆️
...lugins/pendingList/EntryList/InjectEntryDialog.tsx 0% <0%> (ø) ⬆️
...s/pendingList/EntryListHeader/RemoveListDialog.tsx 0% <0%> (ø)
src/plugins/pendingList/EntryList/index.tsx 0% <0%> (ø) ⬆️
src/plugins/pendingList/EntryListHeader/index.tsx 0% <0%> (ø)
src/plugins/pendingList/AddFab/AddListDialog.tsx 0% <0%> (ø)
src/core/tasks/utils.ts 0% <0%> (ø)
src/plugins/pendingList/Entries.tsx 0% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07718b6...e812f54. Read the comment docs.

@kristenmills kristenmills merged commit 6eb06d4 into develop Dec 17, 2019
@kristenmills kristenmills deleted the pending-list-bulk branch December 17, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pending List

1 participant