Skip to content

NPO parameter has changed for only showing full episodes#1616

Merged
cvium merged 3 commits intoFlexget:developfrom
mfonville:develop
Jan 10, 2017
Merged

NPO parameter has changed for only showing full episodes#1616
cvium merged 3 commits intoFlexget:developfrom
mfonville:develop

Conversation

@mfonville
Copy link
Copy Markdown
Contributor

Motivation for changes:

NPO API has changed

Detailed changes:

Addressed issues:

  • Without this fix, also other video objects, like small snippets of episodes are fetched

@liiight
Copy link
Copy Markdown
Member

liiight commented Jan 8, 2017

You forgot to redo cassettes

@mfonville
Copy link
Copy Markdown
Contributor Author

I lack at the moment (access) to a system to re-run the cassettes on :-/
If somebody else could run them, I'd really appreciate it. Otherwise it will have to wait awhile I fear

@mfonville
Copy link
Copy Markdown
Contributor Author

Another I noticed now, is that the testcase also needs an update.
Because it assumed the Trailer was the first season of the series, while in reality it wasn't (I just hadn't discovered yet that the parameter had changed; I only found that out just now, while toying a bit with the HTML and URLs)

@mfonville
Copy link
Copy Markdown
Contributor Author

mfonville commented Jan 9, 2017

I now at least updated the test-case; so if somebody could just re-run the test and update the cassette from that run, it should be good to go

@mfonville
Copy link
Copy Markdown
Contributor Author

Ok, I got hold of a machine for a moment where I could run the test and update the cassettes

@cvium cvium merged commit 030a344 into Flexget:develop Jan 10, 2017
liiight pushed a commit that referenced this pull request Jan 20, 2017
* v2.9.0

* Prepare v2.9.1.dev

* Support searching for titles which contain quotes (#1618)

[change] piratebay: replacing single quotes with spaces as their search engine doesn't like them

* [added] subliminal: added support for .rar files

* NPO parameter has changed for only showing full episodes (#1616)

[change] npo_watchlist: updated to only grab broadcasts; previously it also grabbed trailers

* [fix] est_released_movies: Fixed crash with movie_year of None (#1602)

* [added] convert_magnet: new config option to fail entries if conversion fails, closes #1619

* Don't evaluate 'if' statements on un-needed phases for simple accept/reject actions.

* v2.9.1

* Prepare v2.9.2.dev

* relplace Safe by zxcvbn for password strenght testing (#1620)

* [fix] sickbeard: fixed a typo that caused a crash when 'include_data: yes', fixes #1623

* v2.9.2

* Prepare v2.9.3.dev

* Support for 2160p (#1625)

[added] quality: added support for 2160p

* [Fix][UI] improves version checking, fixes #1617

* [Fix][UI] Removing a show when in search mode, keeps the UI in search page #1559

* [Change][UI] Username is autofilled on login page

* Removed incorrect files

* v2.9.3

* Prepare v2.9.4.dev

* [Add][UI] Config section allows editing of variables

* Added warning regarding variables configuration

* v2.9.4

* Prepare v2.9.5.dev

* added support for Exx identifier in series parser (#1622)

[change] series parser: added support for Exx identifier

* [Add] My Anime List input plugin (#1629)

* [Add] My Anime List input plugin

* Review changes

* Python 3 .values =/= list

* Converting config variables to lists

* Correct list conversion

* v2.9.5

* Prepare v2.9.6.dev

* Update app.py

* Added base_url to webserver config

* Made `base_url` setting a little looser so that `/` is not mandatory

* Update url-interceptor.service.js

* Check base_url exists before prepending /

* Make sure base_url doesn't end with /

* fix api in UI

* Fix log page

* Removed leftover prints

* Fix series and movie posters not loading correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants