[fix] est_released_movies: Fixed crash with movie_year of None#1602
Merged
cvium merged 3 commits intoFlexget:developfrom Jan 10, 2017
Merged
[fix] est_released_movies: Fixed crash with movie_year of None#1602cvium merged 3 commits intoFlexget:developfrom
cvium merged 3 commits intoFlexget:developfrom
Conversation
cvium
requested changes
Jan 1, 2017
flexget/plugins/list/trakt_list.py
Outdated
Contributor
There was a problem hiding this comment.
This line looks like it's over 120 characters.
Contributor
Author
There was a problem hiding this comment.
Good catch, I ran flake8 and the file now has no errors.
Contributor
There was a problem hiding this comment.
Should let the logger handle string formatting ie. pass it as an argument.
cvium
reviewed
Jan 5, 2017
flexget/plugins/list/trakt_list.py
Outdated
Contributor
There was a problem hiding this comment.
Is this pep8-compliant? I would've expected it to be indented more.
Contributor
|
A recent change conflicts with your PR. Please update your PR. |
Contributor
Author
|
rebased |
cvium
approved these changes
Jan 10, 2017
liiight
pushed a commit
that referenced
this pull request
Jan 20, 2017
* v2.9.0 * Prepare v2.9.1.dev * Support searching for titles which contain quotes (#1618) [change] piratebay: replacing single quotes with spaces as their search engine doesn't like them * [added] subliminal: added support for .rar files * NPO parameter has changed for only showing full episodes (#1616) [change] npo_watchlist: updated to only grab broadcasts; previously it also grabbed trailers * [fix] est_released_movies: Fixed crash with movie_year of None (#1602) * [added] convert_magnet: new config option to fail entries if conversion fails, closes #1619 * Don't evaluate 'if' statements on un-needed phases for simple accept/reject actions. * v2.9.1 * Prepare v2.9.2.dev * relplace Safe by zxcvbn for password strenght testing (#1620) * [fix] sickbeard: fixed a typo that caused a crash when 'include_data: yes', fixes #1623 * v2.9.2 * Prepare v2.9.3.dev * Support for 2160p (#1625) [added] quality: added support for 2160p * [Fix][UI] improves version checking, fixes #1617 * [Fix][UI] Removing a show when in search mode, keeps the UI in search page #1559 * [Change][UI] Username is autofilled on login page * Removed incorrect files * v2.9.3 * Prepare v2.9.4.dev * [Add][UI] Config section allows editing of variables * Added warning regarding variables configuration * v2.9.4 * Prepare v2.9.5.dev * added support for Exx identifier in series parser (#1622) [change] series parser: added support for Exx identifier * [Add] My Anime List input plugin (#1629) * [Add] My Anime List input plugin * Review changes * Python 3 .values =/= list * Converting config variables to lists * Correct list conversion * v2.9.5 * Prepare v2.9.6.dev * Update app.py * Added base_url to webserver config * Made `base_url` setting a little looser so that `/` is not mandatory * Update url-interceptor.service.js * Check base_url exists before prepending / * Make sure base_url doesn't end with / * fix api in UI * Fix log page * Removed leftover prints * Fix series and movie posters not loading correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Was seeing a crash when using a list containing a movie with no release date:
It looks like this plugin can't handle a movie_year of none, despite that being a valid value to be passed.
Detailed changes:
Addressed issues:
Config usage if relevant (new plugin or updated schema):
Log and/or tests output (preferably both):