Make ostracon/main based on Tendermint v0.34.8 by torao · Pull Request #194 · Finschia/ostracon

torao · 2021-03-05T06:40:52Z

Closes: #XXX

Description

This PR migrates all previous changes and fixes of Ostracon (formerly LINE Blockchain) applied in Tendermint v0.33.x to ostracon/main, which is based on Tendermint v0.34.8. In addition to Tendermint v0.34.8, Ostracon introduces or fixes the following features:

Proposer election scheme has been changed from predictable round-robin to more secure weighted random sampling based on StakingPower. This uses VRF as a non-falsifiable cryptographic pseudo-random number generator.
In order to modify the incentive scheme, we have changed the consensus to elect a part of the Validators as Voters. We have also changed a part of ABCI to distribute the votes of the selected Voters in the Cosmos SDK reward distribution.
In addition to ed25519, BLS has been added experimentally to the signature scheme for consensus. The BLS signatures contained in a commit are aggregated into a single signature, which is expected to reduce communication costs and storage size.
Reactor has been modified to run asynchronously to improve performance.

Note for reviewers:

Setting up the CI environment, testing, LINTing, etc. are going to do in later tasks. Please ignore these checks in this PR.
The specification of each feature should be pointed out in a separate issue.

For contributor use:

~~Wrote tests~~
~~Updated CHANGELOG_PENDING.md~~
~~Linked to Github issue with discussion and accepted design OR link to spec that describes this work.~~
~~Updated relevant documentation (docs/) and code comments~~
Re-reviewed Files changed in the Github PR explorer

…arts`

…ult to apply VRF)

blockchain/v2/reactor.go

tools/tm-signer-harness/internal/test_harness_test.go

kokehiM0chi · 2021-06-30T05:07:34Z

This folder libs/autofile/_test_HtEYbTB5QlzT is probably an unnecessary folder, so please delete it.

CHANGELOG_OF_TENDERMINT.md

blockchain/v2/reactor.go

consensus/byzantine_test.go

consensus/reactor.go

consensus/state.go

crypto/bls/bls.go

crypto/composite/composite.go

libs/autofile/_test_HtEYbTB5QlzT/myfile.000

rpc/client/mocks/client.go

tnasu

I finished the first review. Please check my comments include nit feedbacks.

config/toml.go

consensus/reactor.go

consensus/state.go

evidence/pool_test.go

libs/autofile/_test_HtEYbTB5QlzT/myfile.000

rpc/client/rpc_test.go

rpc/core/doc.go

scripts/add_validator.sh

scripts/current_branch_lint.sh

scripts/prepare_dredd_test.sh

tnasu · 2021-07-02T05:35:05Z

For building, could you patch the below? (Using 1.15-alpine)

$ git diff
diff --git a/Makefile b/Makefile
index 1c6b0c0e8f..d84c821bf8 100644
--- a/Makefile
+++ b/Makefile
@@ -251,7 +251,7 @@ DOCKER_HOME = /go/src/github.com/tendermint/tendermint
 DOCKER_CMD = docker run --rm \
                         -v `pwd`:$(DOCKER_HOME) \
                         -w $(DOCKER_HOME)
-DOCKER_IMG = golang:1.14.6-alpine3.12
+DOCKER_IMG = golang:1.15-alpine
 BUILD_CMD = apk add --update --no-cache git make gcc libc-dev build-base curl jq file gmp-dev clang \
        && cd $(DOCKER_HOME) \
        && make build
diff --git a/networks/local/localnode/Dockerfile b/networks/local/localnode/Dockerfile
index f47557fca3..ee3a366620 100644
--- a/networks/local/localnode/Dockerfile
+++ b/networks/local/localnode/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.14-alpine
+FROM golang:1.15-alpine
 MAINTAINER Greg Szabo <greg@tendermint.com>
 
 RUN apk update && \
diff --git a/tools/proto/Dockerfile b/tools/proto/Dockerfile
index 5008226904..a056f307e0 100644
--- a/tools/proto/Dockerfile
+++ b/tools/proto/Dockerfile
@@ -1,6 +1,6 @@
 FROM bufbuild/buf:latest as buf
 
-FROM golang:1.14-alpine3.11 as builder
+FROM golang:1.15-alpine as builder
 
 RUN apk add --update --no-cache build-base curl git upx && \
   rm -rf /var/cache/apk/*

Ref:

$ find ./ -type d -name .git -prune -o -type f | xargs grep alpine
.//tools/proto/Dockerfile:FROM golang:1.14-alpine3.11 as builder
.//tools/proto/Dockerfile:FROM alpine:edge
.//tools/proto/Dockerfile:RUN echo 'http://dl-cdn.alpinelinux.org/alpine/edge/testing' >> /etc/apk/repositories && \
.//DOCKER/Dockerfile:FROM golang:1.15-alpine as builder
.//DOCKER/Dockerfile:FROM golang:1.15-alpine
.//Makefile:DOCKER_IMG = golang:1.14.6-alpine3.12
.//networks/local/localnode/Dockerfile:FROM golang:1.14-alpine
grep: .//.git: Is a directory

types/voter_set_test.go

types/validator_set_test.go

kokehiM0chi · 2021-07-02T10:58:29Z

LGTM

test/maverick/consensus/state.go

consensus/state_test.go

torao changed the base branch from develop to v0.34.x March 5, 2021 07:54

torao marked this pull request as draft March 5, 2021 07:55

torao force-pushed the apply_v0.34.8 branch from 594d766 to fa1f5ca Compare March 22, 2021 01:39

torao force-pushed the apply_v0.34.8 branch 2 times, most recently from 9c3dcb5 to efd45b1 Compare April 5, 2021 09:01

torao force-pushed the apply_v0.34.8 branch 4 times, most recently from 204e82d to cf662fb Compare April 21, 2021 08:28

torao force-pushed the apply_v0.34.8 branch 3 times, most recently from 2dafb55 to b8261cf Compare April 30, 2021 09:57

zemyblue and others added 9 commits May 6, 2021 12:20

Fix skipped TestReactorWithTimeoutCommit test

7d15429

Fix TestByzantine

6c968bb

Modify to find proposer directly on `TestReactorRecordsVotesAndBlockP…

2099882

…arts`

fix: reactor test failure

f320883

set resource for the circleci machine

1d2a4e6

fix: skipped tests

93468af

fix: race bug

9cc30b0

fix: apply comment

fd0c521

chore: remove blank line

c804ea2

kokehiM0chi force-pushed the apply_v0.34.8 branch from d80e3dd to 540e616 Compare May 6, 2021 03:21

Woosang Son and others added 8 commits May 6, 2021 12:25

fix: refine forceProposer

fd5622b

fix: remove hard code

5e0258e

fix: refactoring forceProposer

00e37e4

fixed skipped testcase (but in the end, skipped them that were diffic…

43a9444

…ult to apply VRF)

fixed all FIXME, pass all tests

aec9269

Fix race detection error of SelectProposer (unit tests uncompleted)

f1247a9

Fix TestReactorHelperMode error in the blockchain/v2/reactor_test.go

588af48

fix lint warnings.

a8097d7

torao self-assigned this Jun 29, 2021

torao added the G: epic Granularity: Epic issue label Jun 29, 2021

torao added this to the initial ebony milestone Jun 29, 2021

torao force-pushed the apply_v0.34.8 branch from 7ec1a53 to dfe58f6 Compare June 29, 2021 08:34

kokehiM0chi suggested changes Jun 30, 2021

View reviewed changes

blockchain/v2/reactor.go Outdated Show resolved Hide resolved

tools/tm-signer-harness/internal/test_harness_test.go Outdated Show resolved Hide resolved

tnasu reviewed Jun 30, 2021

View reviewed changes

CHANGELOG_OF_TENDERMINT.md Outdated Show resolved Hide resolved

tnasu reviewed Jun 30, 2021

View reviewed changes

blockchain/v2/reactor.go Outdated Show resolved Hide resolved

torao commented Jul 1, 2021

View reviewed changes

tnasu requested changes Jul 1, 2021

View reviewed changes

tnasu requested changes Jul 2, 2021

View reviewed changes

torao force-pushed the apply_v0.34.8 branch 2 times, most recently from 0eb453f to 76eab22 Compare July 2, 2021 08:37

kokehiM0chi self-requested a review July 2, 2021 10:56

kokehiM0chi approved these changes Jul 2, 2021

View reviewed changes

tnasu requested changes Jul 2, 2021

View reviewed changes

test/maverick/consensus/state.go Outdated Show resolved Hide resolved

consensus/state_test.go Outdated Show resolved Hide resolved

merge diffs of branch main to resolve conflicts with it

5df4ea7

torao force-pushed the apply_v0.34.8 branch from 76eab22 to 5df4ea7 Compare July 5, 2021 02:16

tnasu approved these changes Jul 5, 2021

View reviewed changes

torao closed this Jul 5, 2021

torao reopened this Jul 5, 2021

torao merged commit 50b4e78 into main Jul 5, 2021

tnasu deleted the apply_v0.34.8 branch July 7, 2021 05:48

tnasu mentioned this pull request Jul 27, 2022

Swap StakingPower and VotingPower, and modify from StakingPower to VotingWeight #449

Merged

tnasu referenced this pull request in tnasu/ostracon Dec 12, 2022

Fix the bug of Ostracon's changes of #194

aa125f5

tnasu mentioned this pull request Dec 12, 2022

Fix the bug of Ostracon's changes of #194 #526

Merged

tnasu added a commit that referenced this pull request Dec 14, 2022

Fix the bug of Ostracon's changes of #194 (#526)

2f25796

Mdaiki0730 mentioned this pull request Nov 2, 2023

Use the value receiver instead of the pointer receiver in Pubkey.Identity() (Triage on ostracon#492) Finschia/cometbft#10

Closed

Conversation

torao commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Uh oh!

kokehiM0chi commented Jun 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnasu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnasu commented Jul 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kokehiM0chi commented Jul 2, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

torao commented Mar 5, 2021 •

edited

Loading