Fix the bug of Ostracon's changes of #194#526
Merged
tnasu merged 1 commit intoFinschia:mainfrom Dec 14, 2022
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
+ Coverage 65.99% 66.17% +0.17%
==========================================
Files 279 279
Lines 38028 38038 +10
==========================================
+ Hits 25097 25172 +75
+ Misses 11129 11073 -56
+ Partials 1802 1793 -9
|
torao
approved these changes
Dec 14, 2022
kokehiM0chi
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#194 was made of too many things. But, it made some of the wrong changes. Here are the wrong changes:
CheckEvidenceonexecution.go:ValidateBlockRound/Proofonprotobuf.go:HeaderValidatorHashonprotobuf.go:HeaderVotingWeightonvalidator.go:String