Skip to content

Split attestation verification#148

Merged
QuentinI merged 5 commits intocelo-integration-rebase-13from
ag/split-register
May 29, 2025
Merged

Split attestation verification#148
QuentinI merged 5 commits intocelo-integration-rebase-13from
ag/split-register

Conversation

@QuentinI
Copy link
Copy Markdown
Collaborator

@QuentinI QuentinI commented May 23, 2025

Closes #<ISSUE_NUMBER>

This PR:

  • Removes workaround for enclave tests that sets big gas limit
  • Parses the attestation and for each certificate in CA bundle verifies it in a separate transaction

This PR does not:

Key places to review:

How to test this PR:

Same as #144
Note that gas limit hack was removed in this PR, so passing test indicates that we indeed don't create exceedingly big transactions.


@QuentinI QuentinI force-pushed the ag/batchertests-enclave branch from 9ff1b53 to 8bfdf54 Compare May 27, 2025 17:57
@QuentinI QuentinI force-pushed the ag/split-register branch from 6d64084 to 65b647c Compare May 27, 2025 18:02
Base automatically changed from ag/batchertests-enclave to celo-integration-rebase-13 May 28, 2025 17:47
@QuentinI QuentinI force-pushed the ag/split-register branch from 46ace82 to cbb2964 Compare May 28, 2025 18:08
@philippecamacho
Copy link
Copy Markdown
Collaborator

I have got a failure when running the enclave tests.
logs.txt

@QuentinI QuentinI force-pushed the ag/split-register branch from 88e199b to 7c23e7d Compare May 28, 2025 18:35
@EspressoSystems EspressoSystems deleted a comment from CLAassistant May 28, 2025
Comment thread op-batcher/batcher/espresso.go Outdated
Comment thread op-batcher/batcher/espresso.go Outdated
Copy link
Copy Markdown
Collaborator

@philippecamacho philippecamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Minor suggestions.

@QuentinI QuentinI merged commit 4ebcaf3 into celo-integration-rebase-13 May 29, 2025
24 of 29 checks passed
@QuentinI QuentinI deleted the ag/split-register branch May 29, 2025 17:34
QuentinI added a commit that referenced this pull request Jun 18, 2025
QuentinI added a commit that referenced this pull request Jun 20, 2025
shenkeyao pushed a commit that referenced this pull request Jul 18, 2025
shenkeyao pushed a commit that referenced this pull request Jul 18, 2025
dailinsubjam pushed a commit that referenced this pull request Oct 4, 2025
dailinsubjam pushed a commit that referenced this pull request Oct 7, 2025
shenkeyao pushed a commit that referenced this pull request Jan 15, 2026
shenkeyao pushed a commit that referenced this pull request Feb 2, 2026
shenkeyao pushed a commit that referenced this pull request Feb 10, 2026
shenkeyao pushed a commit that referenced this pull request Feb 12, 2026
QuentinI added a commit that referenced this pull request Feb 20, 2026
shenkeyao pushed a commit that referenced this pull request Mar 20, 2026
QuentinI added a commit that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants