6.2 Batcher tests in enclave by QuentinI · Pull Request #144 · EspressoSystems/optimism-espresso-integration

QuentinI · 2025-05-21T17:23:07Z

Closes #<ISSUE_NUMBER>

This PR:

Pulls docker image for enclave back into the main dockerfile
Adds infrastructure for building and starting enclaver EIF images to espresso/environment
Adds infrastructure for batcher-in-enclave tests to espresso/environment, which builds the batcher EIF, registers its PCR0 with attestation verifier and starts the EIF.
Adds a smoke test for batcher in enclave, which mirrors TestE2eDevNetWithEspressoSimpleTransactions, just with batcher in enclave

This PR does not:

Fix gas limit issues
Add any other tests

Key places to review:

How to test this PR:

On a EC2 machine with enclave support:

cd kurtosis-devnet/
just op-batcher-enclave-image
cd ../
export ESPRESSO_RUN_ENCLAVE_TESTS=true
go test ./espresso/enclave-tests/... -v -count 1

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1210220384389444

QuentinI · 2025-05-21T18:17:33Z

flake.nix

This is mostly just reformatting according to nixfmt, the only real change is adding enclaver to the devShell.

dailinsubjam · 2025-05-21T23:38:26Z

Amazing! The test could pass on my ec2 machine. Let's add the test instructions also to the comment on top of the test.

dailinsubjam

I haven't had a chance to review all the code yet, will continue later.

op-e2e/config/init.go

op-batcher/enclave-entrypoint.bash

shenkeyao

Haven't tested this on an EC2 machine yet, but the changes look good!

shenkeyao · 2025-05-22T04:39:54Z

espresso/environment/enclave_helpers.go

+				// TODO(AG): currently op-batcher calls `registerSigner` directly,
+				// which on the first run results in verifying the full certificate
+				// chain in a single transaction, which runs over gas limit. This is
+				// a workaround for the issue, real solution will invole verifying
+				// each cerficiate separately before calling `registerSigner`


Could you add the task link to the comment as well? https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1210016054362985?focus=true (I think this is the corresponding task?).

op-e2e/config/init.go

philippecamacho · 2025-05-22T20:24:14Z

Amazing! The test could pass on my ec2 machine. Let's add the test instructions also to the comment on top of the test.

@dailinsubjam Great indeed. Could you help @QuentinI document how to set up an EC2 instance with an enclave in the Espresso README.md, so that everyone can run the tests on her own?

dailinsubjam · 2025-05-24T03:50:23Z

@philippecamacho Sure! Instruction on how to setup an enclave-enabled EC2 instance added in https://github.com/EspressoSystems/optimism-espresso-integration/pull/152/files.

dailinsubjam

LGTM, there's just too much code for me to go through every detail lol.

philippecamacho · 2025-05-27T22:46:59Z

I get this error

[ec2-user@ip-172-31-42-29 kurtosis-devnet]$ just op-batcher-enclave-image
error: Variable `KURTOSIS_PACKAGE` has multiple definitions
  ——▶ justfile:51:1
   │
51 │ KURTOSIS_PACKAGE := "github.com/ethpandaops/optimism-package"

QuentinI · 2025-05-28T10:22:40Z

I get this error

[ec2-user@ip-172-31-42-29 kurtosis-devnet]$ just op-batcher-enclave-image
error: Variable `KURTOSIS_PACKAGE` has multiple definitions
  ——▶ justfile:51:1
   │
51 │ KURTOSIS_PACKAGE := "github.com/ethpandaops/optimism-package"

Oh, this was an uncaught merge error after rebasing onto celo's updates. Fixed.

philippecamacho · 2025-05-28T14:41:35Z

I get this error now. Maybe I did not configure my EC2 instance correctly.
( I followed Sishan's README.md)

 INFO  enclaver::run > starting egress proxy on vsock port 17002
 INFO  enclaver::vsock > Listening on vsock port 17002
 INFO  enclaver::run   > starting enclave
 ERROR enclaver::nitro_cli > nitro-cli failed (exit status: 39)
 ERROR enclaver::nitro_cli > stderr:
[ E22 ] Insufficient CPUs available in the pool. User provided `cpu-count` is 2, which is more than the configured CPU pool size.
You can increase the CPU pool size by editing the `cpu_count` value from '/etc/nitro_enclaves/allocator.yaml' and then enable the nitro-enclaves-allocator.service.

For more details, please visit https://docs.aws.amazon.com/enclaves/latest/user/cli-errors.html#E22

If you open a support ticket, please provide the error log found at "/var/log/nitro_enclaves/err2025-05-28T14:39:18.206963221+00:00.log"
Failed connections: 1
[ E39 ] Enclave process connection failure. Such error appears when the enclave manager fails to connect to at least one enclave process for retrieving the description information.

For more details, please visit https://docs.aws.amazon.com/enclaves/latest/user/cli-errors.html#E39

If you open a support ticket, please provide the error log found at "/var/log/nitro_enclaves/err2025-05-28T14:39:18.207121071+00:00.log"

 ERROR enclaver::nitro_cli > /var/log/nitro_enclaves/err2025-05-28T14:39:18.206963221+00:00.log:
  Action: Run Enclave
  Subactions:
    Failed to execute command `Run`
    Failed to trigger enclave run
    Failed to get CPU configuration
    Insufficient CPUs available (requested 2, but maximum is 0)
  Root error file: src/enclave_proc/cpu_info.rs
  Root error line: 70
  Version: 1.3.1
 ERROR enclaver::nitro_cli > /var/log/nitro_enclaves/err2025-05-28T14:39:18.207121071+00:00.log:
  Action: Run Enclave
  Subactions:
    Failed to handle all enclave process replies
    Failed to connect to 1 enclave processes
  Root error file: src/enclave_proc_comm.rs
  Root error line: 358
  Version: 1.3.1
Error: failed to run enclave
panic: enclave exited with an error: exit status 1

goroutine 186464 [running]:
github.com/ethereum-optimism/optimism/espresso/environment.(*EnclaverCli).RunEnclave.func1()
	/home/ec2-user/optimism-espresso-integration/espresso/environment/enclave_helpers.go:413 +0x65
created by github.com/ethereum-optimism/optimism/espresso/environment.(*EnclaverCli).RunEnclave in goroutine 157890
	/home/ec2-user/optimism-espresso-integration/espresso/environment/enclave_helpers.go:410 +0x2a5
FAIL	github.com/ethereum-optimism/optimism/espresso/enclave-tests	50.544s

philippecamacho

All tests (enclave and no-enclave) passing.
LGTM

ops/docker/op-stack-go/Dockerfile

QuentinI commented May 21, 2025

View reviewed changes

QuentinI marked this pull request as ready for review May 21, 2025 18:25

dailinsubjam reviewed May 22, 2025

View reviewed changes

op-e2e/config/init.go Outdated Show resolved Hide resolved

op-batcher/enclave-entrypoint.bash Show resolved Hide resolved

shenkeyao reviewed May 22, 2025

View reviewed changes

QuentinI mentioned this pull request May 23, 2025

Split attestation verification #148

Merged

dailinsubjam mentioned this pull request May 24, 2025

Add instructions of setting up enclave-enabled instance to README_ESPRESSO #152

Merged

dailinsubjam approved these changes May 27, 2025

View reviewed changes

QuentinI added 8 commits May 27, 2025 19:57

Batcher enclave test

a2a6d01

Cleanup

8ce39a8

Add missing return

e387955

Fix flag format

473ffa9

Fix EspressoUrls flag

7910a76

Fix poll interval flag

3436414

Suggestions

5a01e51

Add instructions

8bfdf54

QuentinI force-pushed the ag/batchertests-enclave branch from 9ff1b53 to 8bfdf54 Compare May 27, 2025 17:57

QuentinI changed the base branch from celo-integration to celo-integration-rebase-13 May 27, 2025 17:57

Merge branch 'celo-integration-rebase-13' into ag/batchertests-enclave

8c887cb

Fix kurtosis-devnet/justfile

73c7f0e

Remove outdated TODO

6d8c092

Add justfile command

0e10cfe

QuentinI force-pushed the ag/batchertests-enclave branch from 6ffa2a2 to 0e10cfe Compare May 28, 2025 15:25

QuentinI added 2 commits May 28, 2025 17:28

Fix foundry profile

866a8a4

Fix path

9560bb3

Merge branch 'celo-integration-rebase-13' into ag/batchertests-enclave

4e7a4cc

philippecamacho approved these changes May 28, 2025

View reviewed changes

philippecamacho reviewed May 28, 2025

View reviewed changes

ops/docker/op-stack-go/Dockerfile Show resolved Hide resolved

QuentinI merged commit f9ff63e into celo-integration-rebase-13 May 28, 2025
21 of 29 checks passed

QuentinI deleted the ag/batchertests-enclave branch May 28, 2025 17:47

QuentinI added a commit that referenced this pull request Jun 18, 2025

6.2 Batcher tests in enclave (#144)

8b8511f

QuentinI added a commit that referenced this pull request Jun 20, 2025

6.2 Batcher tests in enclave (#144)

0accbb1

QuentinI added a commit that referenced this pull request Jun 20, 2025

6.2 Batcher tests in enclave (#144)

1445797

QuentinI added a commit that referenced this pull request Jun 20, 2025

6.2 Batcher tests in enclave (#144)

f2adf15

QuentinI added a commit that referenced this pull request Jun 20, 2025

6.2 Batcher tests in enclave (#144)

3ac2916

shenkeyao pushed a commit that referenced this pull request Jul 18, 2025

6.2 Batcher tests in enclave (#144)

6ce3d39

shenkeyao pushed a commit that referenced this pull request Jul 18, 2025

6.2 Batcher tests in enclave (#144)

1e4a5e4

dailinsubjam pushed a commit that referenced this pull request Oct 4, 2025

6.2 Batcher tests in enclave (#144)

bdcca74

dailinsubjam pushed a commit that referenced this pull request Oct 7, 2025

6.2 Batcher tests in enclave (#144)

11d478a

shenkeyao mentioned this pull request Nov 26, 2025

Fallback Inbox contract changes #278

Merged

shenkeyao pushed a commit that referenced this pull request Jan 15, 2026

6.2 Batcher tests in enclave (#144)

f54ce82

shenkeyao pushed a commit that referenced this pull request Feb 2, 2026

6.2 Batcher tests in enclave (#144)

4923682

shenkeyao pushed a commit that referenced this pull request Feb 10, 2026

6.2 Batcher tests in enclave (#144)

61249f3

shenkeyao pushed a commit that referenced this pull request Feb 12, 2026

6.2 Batcher tests in enclave (#144)

b9655dc

QuentinI added a commit that referenced this pull request Feb 20, 2026

6.2 Batcher tests in enclave (#144)

4d42582

shenkeyao pushed a commit that referenced this pull request Mar 20, 2026

6.2 Batcher tests in enclave (#144)

b2f7e85

Conversation

QuentinI commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR:

This PR does not:

Key places to review:

How to test this PR:

Uh oh!

QuentinI May 21, 2025

Choose a reason for hiding this comment

Uh oh!

dailinsubjam commented May 21, 2025

Uh oh!

dailinsubjam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shenkeyao left a comment

Choose a reason for hiding this comment

Uh oh!

shenkeyao May 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

philippecamacho commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dailinsubjam commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dailinsubjam left a comment

Choose a reason for hiding this comment

Uh oh!

philippecamacho commented May 27, 2025

Uh oh!

QuentinI commented May 28, 2025

Uh oh!

philippecamacho commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philippecamacho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

QuentinI commented May 21, 2025 •

edited

Loading

philippecamacho commented May 22, 2025 •

edited

Loading

dailinsubjam commented May 24, 2025 •

edited

Loading

philippecamacho commented May 28, 2025 •

edited

Loading