Skip to content

Conversation

@leon
Copy link
Contributor

@leon leon commented Nov 24, 2025

fixes: #722

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

What problem does this PR address?
#722

Solution

How does this PR solve the problem?
Wraps the check in a try catch block and returns false if it throws

Test Plan and Compatibility

What steps have you taken to ensure this PR maintains compataibility with the existing functionality?
It only fixes a bug, does not introduce any changes to code paths.

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: 815eb6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukehb lukehb added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 auto-backport-to-UE5.6 auto-backport-to-UE5.7 labels Nov 25, 2025
@lukehb lukehb merged commit cc8c923 into EpicGamesExt:master Nov 25, 2025
7 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 25, 2025
…hen in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)
github-actions bot pushed a commit that referenced this pull request Nov 25, 2025
…hen in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)
github-actions bot pushed a commit that referenced this pull request Nov 25, 2025
…hen in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)
@github-actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
UE5.5
UE5.6
UE5.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

lukehb added a commit that referenced this pull request Nov 25, 2025
…ystem' when in iframe (#734) (#735)

* SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)

* Fix iframe streaming issue due to SecurityError

---------

Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
lukehb added a commit that referenced this pull request Nov 25, 2025
…ystem' when in iframe (#734) (#736)

* SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)

* Create clever-poems-fail.md

---------

Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
lukehb added a commit that referenced this pull request Nov 25, 2025
…ystem' when in iframe (#734) (#737)

* SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)

* Fix iframe streaming issue due to SecurityError

---------

Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
@leon leon deleted the fix-722 branch November 25, 2025 07:11
@leon
Copy link
Contributor Author

leon commented Nov 25, 2025

Great!

It was such a simple fix, so forgot to run linting, will do that next time. 🤓

mcottontensor added a commit that referenced this pull request Dec 8, 2025
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

* Update RELEASE_VERSION

0.1.1

* Update 5.7 with docs and housekeeping changes (#718)

* Bump markdown link checker version for security patch

#691

* Update link checker to permit 429 code from Github as valid

* Update user-agent in link checker action to try prevent 403 forbidden on some sites

* Update link checker to accept HTTP status 403 (forbidden)

* Remove broken link about eslint

* Modify README for mediasoup-sdp-bridge to remove broken link

Updated README to reflect fork status and removed badges.

* Update workflow triggers for markdown files in push and PR

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709)

* Bring 5.7 changes to master branch (docs + sdpMid fix) (#716)

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update copyright notice

* Update copyright notice in CONTRIBUTING.md

* Update copyright notice

* Update copyright in frontend/readme.md

* Delete .changeset/light-games-wonder.md

---------

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Cut new GH release for 5.7 - 0.1.2

* [UE5.7] Exposed playerid (#728) (#729)

* Exposed playerid (#728)

(cherry picked from commit 6733632)

* Expose player id and improve signalling library

Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature.

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#730)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731)

* Update PeerConnectionController.ts (#719)

Fix for throwing error when peerConnection is not defined

(cherry picked from commit 9a5cd8e)

* Create polite-knives-hang.md

---------

Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737)

* SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)

* Fix iframe streaming issue due to SecurityError

---------

Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#732)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Updating npm publish for new npmjs trusted publisher stuff. (#744)

* Trying to figure out OIDC

* Trying to debug OIDC issues.

* Duplicating id-token

* Still debugging OIDC issues. Adding debugging steps.

* Debugging OIDC.

* Fix OIDC (#745)

* Updating npm to allow oidc auth

* bumping common patch version to test publish.

* Fixing up package info.

* Fix link descriptions for UE 5.7 (#743) (#747)

(cherry picked from commit ff2b1bf)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
mcottontensor added a commit that referenced this pull request Dec 8, 2025
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

* Update RELEASE_VERSION

0.1.1

* Update 5.7 with docs and housekeeping changes (#718)

* Bump markdown link checker version for security patch

#691

* Update link checker to permit 429 code from Github as valid

* Update user-agent in link checker action to try prevent 403 forbidden on some sites

* Update link checker to accept HTTP status 403 (forbidden)

* Remove broken link about eslint

* Modify README for mediasoup-sdp-bridge to remove broken link

Updated README to reflect fork status and removed badges.

* Update workflow triggers for markdown files in push and PR

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709)

* Bring 5.7 changes to master branch (docs + sdpMid fix) (#716)

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update copyright notice

* Update copyright notice in CONTRIBUTING.md

* Update copyright notice

* Update copyright in frontend/readme.md

* Delete .changeset/light-games-wonder.md

---------

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Cut new GH release for 5.7 - 0.1.2

* [UE5.7] Exposed playerid (#728) (#729)

* Exposed playerid (#728)

(cherry picked from commit 6733632)

* Expose player id and improve signalling library

Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature.

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#730)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731)

* Update PeerConnectionController.ts (#719)

Fix for throwing error when peerConnection is not defined

(cherry picked from commit 9a5cd8e)

* Create polite-knives-hang.md

---------

Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737)

* SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)

* Fix iframe streaming issue due to SecurityError

---------

Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#732)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Updating npm publish for new npmjs trusted publisher stuff. (#744)

* Trying to figure out OIDC

* Trying to debug OIDC issues.

* Duplicating id-token

* Still debugging OIDC issues. Adding debugging steps.

* Debugging OIDC.

* Fix OIDC (#745)

* Updating npm to allow oidc auth

* bumping common patch version to test publish.

* Fixing up package info.

* Fix link descriptions for UE 5.7 (#743) (#747)

(cherry picked from commit ff2b1bf)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* Updated NPM changelogs (#749)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fixing repo url.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 auto-backport-to-UE5.6 auto-backport-to-UE5.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

2 participants