Make generateStats not error if peerconnection is undefined #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for throwing error when peerConnection is not defined
|
lukehb
approved these changes
Nov 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
Fix for throwing error when peerConnection is not defined (cherry picked from commit 9a5cd8e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
lukehb
added a commit
that referenced
this pull request
Nov 24, 2025
* Update PeerConnectionController.ts (#719) Fix for throwing error when peerConnection is not defined (cherry picked from commit 9a5cd8e) * Create polite-knives-hang.md --------- Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
mcottontensor
added a commit
that referenced
this pull request
Dec 8, 2025
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump * Update RELEASE_VERSION 0.1.1 * Update 5.7 with docs and housekeeping changes (#718) * Bump markdown link checker version for security patch #691 * Update link checker to permit 429 code from Github as valid * Update user-agent in link checker action to try prevent 403 forbidden on some sites * Update link checker to accept HTTP status 403 (forbidden) * Remove broken link about eslint * Modify README for mediasoup-sdp-bridge to remove broken link Updated README to reflect fork status and removed badges. * Update workflow triggers for markdown files in push and PR * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) * Bring 5.7 changes to master branch (docs + sdpMid fix) (#716) * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update copyright notice * Update copyright notice in CONTRIBUTING.md * Update copyright notice * Update copyright in frontend/readme.md * Delete .changeset/light-games-wonder.md --------- Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Cut new GH release for 5.7 - 0.1.2 * [UE5.7] Exposed playerid (#728) (#729) * Exposed playerid (#728) (cherry picked from commit 6733632) * Expose player id and improve signalling library Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature. --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#730) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731) * Update PeerConnectionController.ts (#719) Fix for throwing error when peerConnection is not defined (cherry picked from commit 9a5cd8e) * Create polite-knives-hang.md --------- Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737) * SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) * fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe fixes: #722 * Update Frontend/library/src/WebXR/WebXRController.ts * Update Frontend/library/src/WebXR/WebXRController.ts --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> (cherry picked from commit cc8c923) * Fix iframe streaming issue due to SecurityError --------- Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#732) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Updating npm publish for new npmjs trusted publisher stuff. (#744) * Trying to figure out OIDC * Trying to debug OIDC issues. * Duplicating id-token * Still debugging OIDC issues. Adding debugging steps. * Debugging OIDC. * Fix OIDC (#745) * Updating npm to allow oidc auth * bumping common patch version to test publish. * Fixing up package info. * Fix link descriptions for UE 5.7 (#743) (#747) (cherry picked from commit ff2b1bf) Co-authored-by: Flo Edelmann <git@flo-edelmann.de> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
mcottontensor
added a commit
that referenced
this pull request
Dec 8, 2025
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump * Update RELEASE_VERSION 0.1.1 * Update 5.7 with docs and housekeeping changes (#718) * Bump markdown link checker version for security patch #691 * Update link checker to permit 429 code from Github as valid * Update user-agent in link checker action to try prevent 403 forbidden on some sites * Update link checker to accept HTTP status 403 (forbidden) * Remove broken link about eslint * Modify README for mediasoup-sdp-bridge to remove broken link Updated README to reflect fork status and removed badges. * Update workflow triggers for markdown files in push and PR * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) * Bring 5.7 changes to master branch (docs + sdpMid fix) (#716) * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update copyright notice * Update copyright notice in CONTRIBUTING.md * Update copyright notice * Update copyright in frontend/readme.md * Delete .changeset/light-games-wonder.md --------- Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Cut new GH release for 5.7 - 0.1.2 * [UE5.7] Exposed playerid (#728) (#729) * Exposed playerid (#728) (cherry picked from commit 6733632) * Expose player id and improve signalling library Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature. --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#730) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731) * Update PeerConnectionController.ts (#719) Fix for throwing error when peerConnection is not defined (cherry picked from commit 9a5cd8e) * Create polite-knives-hang.md --------- Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737) * SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) * fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe fixes: #722 * Update Frontend/library/src/WebXR/WebXRController.ts * Update Frontend/library/src/WebXR/WebXRController.ts --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> (cherry picked from commit cc8c923) * Fix iframe streaming issue due to SecurityError --------- Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#732) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Updating npm publish for new npmjs trusted publisher stuff. (#744) * Trying to figure out OIDC * Trying to debug OIDC issues. * Duplicating id-token * Still debugging OIDC issues. Adding debugging steps. * Debugging OIDC. * Fix OIDC (#745) * Updating npm to allow oidc auth * bumping common patch version to test publish. * Fixing up package info. * Fix link descriptions for UE 5.7 (#743) (#747) (cherry picked from commit ff2b1bf) Co-authored-by: Flo Edelmann <git@flo-edelmann.de> * Updated NPM changelogs (#749) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing repo url. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Fix for throwing error when peerConnection is not defined
Solution
Method is not called when object is not defined
Documentation
If you added a new feature or changed an existing feature please add some documentation here.
Or better yet, link to the relevant
/Docsupdate in your PR.Test Plan and Compatibility
What steps have you taken to ensure this PR maintains compataibility with the existing functionality?
Or better yet, link to the unit tests that accompany this PR.