Action audit #565
Merged
Action audit #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lukehb
reviewed
Apr 3, 2025
|
|
||
| - name: Build common library | ||
| working-directory: ./Common | ||
| run: npm install && npm run build |
lukehb
reviewed
Apr 3, 2025
| - "Frontend/**" | ||
| - "Signalling/**" | ||
| - "SignallingWebServer/**" | ||
| - "Extras/**" |
Contributor
There was a problem hiding this comment.
Okay, so we are saying only do healthcheck on PR now. I think that makes sense.
Collaborator
Author
There was a problem hiding this comment.
Yeah. Generally the only way things should get into the repo is via PR and we should only merge the PR if the actions pass. So there should be no reason to do it on push.
lukehb
approved these changes
Apr 3, 2025
Contributor
lukehb
left a comment
There was a problem hiding this comment.
Looks like a good change to me.
One unrelated thing this reminded me of is I think we could optimise start.bat --build time by only building esm instead of both cjs and esm. As in that case, you only care about getting something up and running, if you somehow broke cjs and not esm the PR would catch it anyway.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
- Removing duplicated push and pull_request triggers - Removing multiple install commands when one root will work. - Removing references to UE5.5 in favor of wildcard matching (cherry picked from commit 4ee5695)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
Apr 3, 2025
- Removing duplicated push and pull_request triggers - Removing multiple install commands when one root will work. - Removing references to UE5.5 in favor of wildcard matching (cherry picked from commit 4ee5695) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
mcottontensor
added a commit
that referenced
this pull request
Apr 8, 2025
* Action audit (#565) (#566) - Removing duplicated push and pull_request triggers - Removing multiple install commands when one root will work. - Removing references to UE5.5 in favor of wildcard matching (cherry picked from commit 4ee5695) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * [UE5.5] Moved frontend library from a peer dep to a normal dep in ui-library (#568) (#569) * Moved frontend library from a peer dep to a normal dep in ui-library (#568) (cherry picked from commit e255bc0) # Conflicts: # Frontend/ui-library/package.json # package-lock.json * Fixing package-lock issues * Fixing issue where workspace path doesnt exist in npm publish action (#570) (#571) Trying to also fix issues with the changelog update perms. (cherry picked from commit 4f9b8a7) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * Trying to fix changelog update action * Still trying to fix changeset update action * What a nightmare * Updated NPM changelogs (#572) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing publish action. * Fixing publish action more. * Wrong package file. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mcottontensor
added a commit
that referenced
this pull request
Apr 8, 2025
* Action audit (#565) (#566) - Removing duplicated push and pull_request triggers - Removing multiple install commands when one root will work. - Removing references to UE5.5 in favor of wildcard matching (cherry picked from commit 4ee5695) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * [UE5.5] Moved frontend library from a peer dep to a normal dep in ui-library (#568) (#569) * Moved frontend library from a peer dep to a normal dep in ui-library (#568) (cherry picked from commit e255bc0) # Conflicts: # Frontend/ui-library/package.json # package-lock.json * Fixing package-lock issues * Fixing issue where workspace path doesnt exist in npm publish action (#570) (#571) Trying to also fix issues with the changelog update perms. (cherry picked from commit 4f9b8a7) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * Trying to fix changelog update action * Still trying to fix changeset update action * What a nightmare * Updated NPM changelogs (#572) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing publish action. * Fixing publish action more. * Wrong package file. * Fix: Various input issues with input into streamed UE widgets (including IME support) (#564) (#575) * Add stub of editTextModal to application * Added events for showing onscreen keyboard, hooked them up to an edit text modal * Added explicitly stopping event propogation on text input into stream UI bleeding into UE keyboard input * Added hidden text box input for desktop IME use * Added config option to not show the modal * Added new docs page about typing into streamed inputs * Remove oncomposition event from keyboard controller as they were only needed for IME input which is now handled via modal * Removed now unused styles from PixelStreamingApplicationStyles.ts * Update Typing into streamed text inputs.md Mentioned the use of software cursor as an option. --------- Co-authored-by: Matthew.Cotton <matt@tensorworks.com.au> (cherry picked from commit 5fb6eb6) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Platform scripts audit (#567) (#577) * Limited the bash script to build cjs * Added a cjs build target * Updating bash script to be a little more friendly with builds. * Added rebuild options to bash script * Updating windows batch script to be inline with bash script. * Cleaned up arguments further for the bash script * Tweaking build behaviour. Updating args * Sorting out webpack configs (cherry picked from commit f7abd33) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * Updated NPM changelogs (#576) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
mcottontensor
added a commit
that referenced
this pull request
Apr 8, 2025
* Action audit (#565) (#566) - Removing duplicated push and pull_request triggers - Removing multiple install commands when one root will work. - Removing references to UE5.5 in favor of wildcard matching (cherry picked from commit 4ee5695) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * [UE5.5] Moved frontend library from a peer dep to a normal dep in ui-library (#568) (#569) * Moved frontend library from a peer dep to a normal dep in ui-library (#568) (cherry picked from commit e255bc0) # Conflicts: # Frontend/ui-library/package.json # package-lock.json * Fixing package-lock issues * Fixing issue where workspace path doesnt exist in npm publish action (#570) (#571) Trying to also fix issues with the changelog update perms. (cherry picked from commit 4f9b8a7) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * Trying to fix changelog update action * Still trying to fix changeset update action * What a nightmare * Updated NPM changelogs (#572) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing publish action. * Fixing publish action more. * Wrong package file. * Fix: Various input issues with input into streamed UE widgets (including IME support) (#564) (#575) * Add stub of editTextModal to application * Added events for showing onscreen keyboard, hooked them up to an edit text modal * Added explicitly stopping event propogation on text input into stream UI bleeding into UE keyboard input * Added hidden text box input for desktop IME use * Added config option to not show the modal * Added new docs page about typing into streamed inputs * Remove oncomposition event from keyboard controller as they were only needed for IME input which is now handled via modal * Removed now unused styles from PixelStreamingApplicationStyles.ts * Update Typing into streamed text inputs.md Mentioned the use of software cursor as an option. --------- Co-authored-by: Matthew.Cotton <matt@tensorworks.com.au> (cherry picked from commit 5fb6eb6) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Platform scripts audit (#567) (#577) * Limited the bash script to build cjs * Added a cjs build target * Updating bash script to be a little more friendly with builds. * Added rebuild options to bash script * Updating windows batch script to be inline with bash script. * Cleaned up arguments further for the bash script * Tweaking build behaviour. Updating args * Sorting out webpack configs (cherry picked from commit f7abd33) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> * Updated NPM changelogs (#576) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Rebuilt package-lock --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going over the actions and doing a few things.