ci: gitignore .shipper/ and pass --allow-dirty to shipper preflight#567
Conversation
The shipper publish workflow failed at preflight: [info] checking git cleanliness... Error: git working tree is not clean; commit/stash changes or use --allow-dirty Our `Plan` step creates `.shipper/plan.txt` via `tee`, which makes the working tree dirty for any subsequent shipper command that checks git cleanliness. Two fixes, belt-and-suspenders: 1. Add `.shipper/` to `.gitignore` so shipper's own state directory is never accidentally committed and doesn't dirty the tree from git's point of view. 2. Pass `--allow-dirty` to `shipper preflight` in both `release.yml` and `publish-retry.yml` so even if shipper writes other state into the working tree at runtime, preflight doesn't reject the run. After this lands, dispatch publish-retry on v0.7.0 again to finish the publish (3 of 53 crates are already on crates.io at 0.7.0; shipper will reconcile against the registry and continue from the rest).
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#567 added --allow-dirty to `shipper preflight`, but the live publish run still failed: [1/53] Publishing uselesskey-aws-lc-rs@0.7.0... (1.533µs) Error: git working tree is not clean; commit/stash changes or use --allow-dirty `shipper publish` and `shipper resume` also check git cleanliness up- front. Add `--allow-dirty` to both invocations in `release.yml` and `publish-retry.yml` so the same `.shipper/plan.txt` output that the Plan step writes via `tee` doesn't trip the subsequent commands. This is the in-flight v0.7.0 unblock; the long-term fix (`.shipper/` already gitignored in #567, optionally writing the plan to a path outside the workspace) keeps applying from v0.8.0 onward.
Summary
Unblock the v0.7.0 shipper publish. After #566 migrated to shipper, the live publish failed at preflight:
```
[info] checking git cleanliness...
Error: git working tree is not clean; commit/stash changes or use --allow-dirty
```
Our `Plan` step writes `.shipper/plan.txt` via `tee` (per shipper's GitHub Actions how-to). That dirties the working tree, so `shipper preflight --policy safe` rejects the run.
Fix
Belt-and-suspenders:
After this PR merges
Dispatch `publish-retry.yml` on `v0.7.0` again. 3 of 53 crates are already on crates.io at 0.7.0; shipper will reconcile against the registry and continue from the rest.
Test plan