Skip to content

Exclude Dynamo Test PDB #9615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Apr 2, 2019
Merged

Exclude Dynamo Test PDB #9615

QilongTang merged 2 commits into from
Apr 2, 2019

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 1, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Follow up PR of #9608. After discussion with other component teams and from internal feedback, remove the test pdb files from symbol nuget. Although it does not hurt, it will be clearer this way.

Latest result:
image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@aparajit-pratap @mjkkirschner

FYIs

@DynamoDS/dynamo

@QilongTang
Copy link
Contributor Author

QilongTang commented Apr 1, 2019

Once this is passed, I am leaning towards cherry-pick the changes into RC2.2.0 for integrators testing. Let me know if you object.

@QilongTang
Copy link
Contributor Author

QilongTang commented Apr 2, 2019

Got LGTM, merging

@QilongTang QilongTang merged commit 2554c47 into master Apr 2, 2019
@QilongTang QilongTang deleted the ExcludeTestPDB branch April 2, 2019 14:59
QilongTang added a commit that referenced this pull request Apr 2, 2019
@QilongTang
Exclude Dynamo Test PDB (#9615)
a33b0d6 
* Exclude Test PDB files

* Simplify the change
@QilongTang QilongTang mentioned this pull request Apr 2, 2019
Merged
7 tasks
QilongTang added a commit that referenced this pull request Apr 2, 2019
@QilongTang
[Cherry-pick] Symbol Nuget and 2.2 Nuget Release (#9617)
17e8a2f 
* Kicking off DynamoCoreSymbols Nuget Package (#9608)

* Alter build package batch file and create new nuspec

* Add comments and improve console messaging

* exclude pdb files not owned by Dynamo team

* Update all the licencing info

* Exclude Dynamo Test PDB (#9615)

* Exclude Test PDB files

* Simplify the change

* nuget release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QilongTang