Kicking off DynamoCoreSymbols Nuget Package #9608
Conversation
|
LGTM |
|
hmm @QilongTang can we only provide our own .pdbs? I'm not sure we should distribute any pdbs but our own in this package. (ie remove cefsharp) |
|
@mjkkirschner I believe I have removed all the pdb files not owned by our team, please let me know if the final package sample looks OK for you guys. |
| </metadata> | ||
| <files> | ||
| <file src="*.pdb" target="lib\net47" /> | ||
| <file src="*.pdb" target="lib\net47" exclude="CefSharp*.pdb;Helix*.pdb;MIConvexHull.NET Standard.pdb"/> |
There was a problem hiding this comment.
hmm, can we pull this out into a variable at the top of the file? we're going to forget to update this list.
There was a problem hiding this comment.
I don't think we can do this because this is an XML with schema defined here: https://docs.microsoft.com/en-us/nuget/reference/nuspec#general-form-and-schema
tools/NuGet/template-artifactory/DynamoVisualProgramming.DynamoCoreSymbols.nuspec
Outdated
Show resolved
Hide resolved
|
@QilongTang do we need to do anything else to get this uploaded automatically? If you are looking at this already - anyway to get the upload user into the new nuget dynamo org? |
|
@QilongTang yes, this should match however we distribute the source. |
|
@mjkkirschner I don't think we need to do anything else rather than merging this. This will not go to public nuget so publisher will be our build machine on artifactory |
|
@mjkkirschner Updated to use all same licencing and year of copy right |
|
LGTM |
|
@QilongTang do we really need to publish pdb's for test assemblies as well? |
|
@aparajit-pratap @mjkkirschner For simplicity, let's skip all the test related pdb files see referenced PR |
* Alter build package batch file and create new nuspec * Add comments and improve console messaging * exclude pdb files not owned by Dynamo team * Update all the licencing info
* Kicking off DynamoCoreSymbols Nuget Package (#9608) * Alter build package batch file and create new nuspec * Add comments and improve console messaging * exclude pdb files not owned by Dynamo team * Update all the licencing info * Exclude Dynamo Test PDB (#9615) * Exclude Test PDB files * Simplify the change * nuget release
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
DYN-1739
As a Dynamo integrator, I would like to use Dynamo pdb files from release build for CER diagnosing.
This PR:
Adds another nuspec file for a new nuget package @DynamoDS/dynamo Team will manage going forward internally to provide support for all Dynamo integrators
Improve console messaging by using
@echo offwhen running this script so we do not log wrong informationUpdates nupkg description for
DynamoCoreRuntimeDeclarations
Check these if you believe they are true
*.resxfilesReviewers
@scottmitchell @mjkkirschner
FYIs
@DynamoDS/dynamo