Skip to content

DYN-6313 Block recommended nodes when TOU not accepted #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Dec 12, 2023
Merged

DYN-6313 Block recommended nodes when TOU not accepted #14735

QilongTang merged 1 commit into from
Dec 12, 2023

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 11, 2023 •
edited
Loading

Purpose

Block recommended nodes when TOU is not accepted.

MLNodeAutoCompleteTOUDisagree_3

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Block recommended nodes when TOU is not accepted.

Reviewers

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 3.0 milestone Dec 11, 2023
@github-actions
Copy link

github-actions bot commented Dec 11, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Dec 11, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@QilongTang QilongTang merged commit 4aad9f2 into master Dec 12, 2023
@QilongTang QilongTang deleted the AutoCompleteMLTOU branch December 12, 2023 13:57
QilongTang added a commit that referenced this pull request Dec 12, 2023
@QilongTang
block recommended nodes when TOU not accepted (#14735)
bc6bbdb
@QilongTang QilongTang mentioned this pull request Dec 12, 2023
Merged
9 tasks
QilongTang added a commit that referenced this pull request Dec 12, 2023
@QilongTang
[Cherry-Pick] block recommended nodes when TOU not accepted (#14735) (#…
eced322 
…14746)

* block recommended nodes when TOU not accepted (#14735)

* update tests to use none ML AutoComplete (#14748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@QilongTang