Skip to content

AGD-3085 : fix cast crash #14351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BogdanZavu merged 1 commit into from
Aug 31, 2023
Merged

AGD-3085 : fix cast crash #14351

BogdanZavu merged 1 commit into from
Aug 31, 2023

Conversation

@BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Aug 30, 2023

Purpose

Fix a crash when the renderPackage is not a HelixRenderPackage

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

@QilongTang
Copy link
Contributor

QilongTang commented Aug 30, 2023

Nice catch, can the crash case be written into a unit test?

@BogdanZavu
Copy link
Contributor Author

BogdanZavu commented Aug 30, 2023

@saintentropy @twastvedt FYI

@BogdanZavu
Copy link
Contributor Author

BogdanZavu commented Aug 31, 2023

@QilongTang I think this is more of an integration test ; this utility is not covered and it's usage is related to a more complex workflow which involves rendering - but it will be tested as part of player integration tests which are in the works.

@BogdanZavu BogdanZavu merged commit e4ef88c into DynamoDS:master Aug 31, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Aug 31, 2023

@QilongTang I think this is more of an integration test ; this utility is not covered and it's usage is related to a more complex workflow which involves rendering - but it will be tested as part of player integration tests which are in the works.

Thank you! Make sense

BogdanZavu added a commit to BogdanZavu/Dynamo that referenced this pull request Sep 6, 2023
@BogdanZavu @zavub
fix cast crash (DynamoDS#14351)
dd62f28 
Co-authored-by: Bogdan Zavu <bogdan.zavu@autodesk.com>
BogdanZavu added a commit to BogdanZavu/Dynamo that referenced this pull request Sep 6, 2023
@BogdanZavu @zavub
fix cast crash (DynamoDS#14351)
56b61dd 
Co-authored-by: Bogdan Zavu <bogdan.zavu@autodesk.com>
QilongTang pushed a commit that referenced this pull request Sep 6, 2023
@BogdanZavu @zavub
fix cast crash (#14351) (#14385)
d6e0262 
Co-authored-by: Bogdan Zavu <bogdan.zavu@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BogdanZavu @QilongTang @zavub