Skip to content

AGD-9999 : fix cast crash #14385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Sep 6, 2023
Merged

AGD-9999 : fix cast crash #14385

QilongTang merged 1 commit into from
Sep 6, 2023

Conversation

@BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Sep 6, 2023 •
edited
Loading

Purpose

Cherry-pick from master.
Just in case we'll need to continue with 2.19 in the next major Revit.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

@BogdanZavu @zavub
fix cast crash (DynamoDS#14351)
56b61dd 
Co-authored-by: Bogdan Zavu <bogdan.zavu@autodesk.com>
@BogdanZavu
Copy link
Contributor Author

BogdanZavu commented Sep 6, 2023

Hey @QilongTang I think it is better to have this in 2.19 after all just in case we need to deliver Player 2.0 based on it in the next Revit Major version.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

⚠️ [run-bin-diff] - Files Added/Deleted::72 new file(s) have been added and 153 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::12 new file(s) have been added and 29 file(s) have been deleted!

@QilongTang QilongTang added this to the 2.19.0 milestone Sep 6, 2023
@QilongTang QilongTang merged commit d6e0262 into DynamoDS:RC2.19.0_master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@BogdanZavu @QilongTang