Change analytics code block position for both controls, Nodeautocomplete and Incanvas search #11232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // When launching this control, always start with clear search term. | ||
| SearchTextBox.Clear(); | ||
|
|
||
| Analytics.TrackEvent( |
Contributor
There was a problem hiding this comment.
Doesn't this get called twice - once when the control becomes visible and once when it gets hidden?
Contributor
Author
There was a problem hiding this comment.
if (!(bool)e.NewValue)
this takes care of those cases when control hides.
Contributor
|
@zeusongit Let's merge this and cherry-pick to 2.9.0 branch |
QilongTang
pushed a commit
that referenced
this pull request
Nov 5, 2020
…Nodeautocomplete and Incanvas search (#11232) (#11235) * Skip primitive type input ports from node-autocomplete (#11201) * Add list of nodes to be skipped * Add test and comments * Add Analytics Coverage for Node AutoComplete (#11209) * add analytics coverage for node autocomplete Open auto complete window Select suggestion * Update NodeAutoCompleteSearchControl.xaml.cs * add tracking to in-canvas search node selection * add track points for in canvas search open/select Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com> * cherrypicking adp code change for node auto Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ADP tracking for in-canvas search control was being recorded incorrectly as it was also triggered right after startup.
Therefore, it is now moved to the function that handles visibility change for both the controls to maintain uniformity and accurate hits.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo